Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1911191imu; Thu, 17 Jan 2019 05:25:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN6Jryz0mHwvdabU25+U4O4UGUHxaDULmrcR+7ibng3TQh6ERRRWVe+YAcffnIm19xhKMjuw X-Received: by 2002:a62:1542:: with SMTP id 63mr15007719pfv.230.1547731520040; Thu, 17 Jan 2019 05:25:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547731520; cv=none; d=google.com; s=arc-20160816; b=MsLx1D+Pt7Y8gy5paOktRiThFw9keQr5Q27GYtMG4TA7yO4kkfgfPE/jbOqEqSXe4A KdGw2JQE/HjmUd6x4yst5BxZWPR+8gYYaZv8XLlicHeRm4t4HhANpG2QTBD72pQjlp9L ymEOH6cjck8wzuRhHhwFSSStGhAFP3QxPoWgV9mGFo8OWnsDY5f8yWJ+27SAT6Uzt7DB Mupha2SuqfWB4TCXY/Lkff6ZYJ+gHgV0JXKEoihpdnBqDtUaXPKJPmKsCTJosNABhNAj qg4VUFfRsf9XYFyJv4vb7nXTOkLNPB0QDxJVa6QKpEWmf5noLqcPBc0HvIHlTS4MwUOw s9lA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=jq+6Np/fMlcGZKPmTPBsY+GDhmY+Gp8cPsJZFO8SCDY=; b=xzM7dwP3253sCkrYjNijlVk+4YMvFUDHbv7Ju/a9ous3cvS2ZD2xeIqIA0diOhIa8D 2fLQ0/NL+iFxLMPPXl2Y8XSXBquMHZpcqTvD1b2JHOkUsAWT8BJpPl85h8Ya1VkAOozG NnlPU0XghFx7fsQv3LlUxNVpcwynDCZsnzOx6NSvuFqc1W4l8enIAz9DrqTr0rPDaBDJ dQGBalCMdE5J96HCO01t3QUVZ077M75EK7FJ08KMAqvdGHxfHbIOF0W8LtxxGOXNjOqS IGEziVZZfFwBA015jlmZEUkAHXYDsP+BglZWlHkP1nrKiZ8eEU/ZNkXy0BzGwJEDhXku Y+JA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e0xzsqTt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s71si1750655pfk.105.2019.01.17.05.25.03; Thu, 17 Jan 2019 05:25:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=e0xzsqTt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbfAQMEs (ORCPT + 99 others); Thu, 17 Jan 2019 07:04:48 -0500 Received: from mail-oi1-f196.google.com ([209.85.167.196]:33194 "EHLO mail-oi1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbfAQMEs (ORCPT ); Thu, 17 Jan 2019 07:04:48 -0500 Received: by mail-oi1-f196.google.com with SMTP id c206so5980114oib.0 for ; Thu, 17 Jan 2019 04:04:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jq+6Np/fMlcGZKPmTPBsY+GDhmY+Gp8cPsJZFO8SCDY=; b=e0xzsqTtUc3IuNXRLBb3yRrHWClhB5WxU9+OqsOaj8j5WHrglmbIndO+cF0s5Z7w90 ir+tYR7r+Wft9LypTxXqNnXkt49V0STBgFW34SbsryHQzXAFczLwmnik0p5YZvwQHZQr H787RDAxeEAK1i/Yv05Um5QD+GoCQkD3oO6s4FNPQpaIOd0fhoy0xd4WvX+lSprUEUYU VvnCVCSZR7yACqlI1VFzZFxij+iNly/5VYft1xCfvirn0XU4xnLIU/aVa2/tY1k6Jib/ 5S655SEhU2rB2wgXyWFHGkY+ihVVoWkPMuV7kso2A6mVN0sNGNdcncDKS2uForYr87F3 D18Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jq+6Np/fMlcGZKPmTPBsY+GDhmY+Gp8cPsJZFO8SCDY=; b=V0Vaf2z/JlVr6JVwaA38sZ71srm7NS07lJ3akxafPyiTsKFOo7oM20dBBNWHOqTMfg i1OHxxLLSfL9OpvtF+hS5A/3TPx/oawYHQ9sxubSBx7+DC9lipU8g60Edurbi2cYhACI +unUjpV+aLYxD6BnDTFk7GY8fQGWwHvWD0tPbfXCW4zRjf3Q//wMYkXBXLVe0RSJJrzN dZ1sdUM6y+QlK+5es1pzn8RUaFCM9Tet2ilHOBPhkjzmKxcgzSYOOUtTY3RRRk35AZRV Xhx+gOhVyD2uPUhrYBPXsIK7MEf/WjDM0krowMW4qIjAVnsG1f9yAIQKbC8KJHRuig7K kDKQ== X-Gm-Message-State: AJcUuke+brX83ACxqXxdWfWpGdyGskWWPH5otItMJwrde51ecozOaiL9 Jezixx5VMjVxT7r7ozU+Pty0pNoA6nFtTA8PCqE= X-Received: by 2002:aca:3092:: with SMTP id w140mr5790872oiw.237.1547726687871; Thu, 17 Jan 2019 04:04:47 -0800 (PST) MIME-Version: 1.0 References: <20190117090640.12972-1-stefan@agner.ch> <20190117090640.12972-4-stefan@agner.ch> In-Reply-To: <20190117090640.12972-4-stefan@agner.ch> From: Fabio Estevam Date: Thu, 17 Jan 2019 10:04:38 -0200 Message-ID: Subject: Re: [alsa-devel] [PATCH 4/5] ASoC: imx-sgtl5000: put of nodes if finding codec fails To: Stefan Agner Cc: timur@kernel.org, Nicolin Chen , Xiubo Li , Linux-ALSA , linux-kernel , Takashi Iwai , Liam Girdwood , Mark Brown , Fabio Estevam Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On Thu, Jan 17, 2019 at 7:07 AM Stefan Agner wrote: > > Make sure to properly put the of node in case finding the codec > fails. > > Fixes: 81e8e4926167 ("ASoC: fsl: add sgtl5000 clock support for imx-sgtl5000") > Signed-off-by: Stefan Agner Looks good. I would suggest making this patch the first one of the series, since it is a bug fix and could potentially be applied to stable. Thanks