Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1986199imu; Thu, 17 Jan 2019 06:35:56 -0800 (PST) X-Google-Smtp-Source: ALg8bN5iwMn3+1nuDhJohMhW65kFtTQmWigoWBEdRfMPxmuV5dENtZuGT0tDaUfNsHH23naDeiFl X-Received: by 2002:a17:902:5ac7:: with SMTP id g7mr15296967plm.212.1547735756663; Thu, 17 Jan 2019 06:35:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547735756; cv=none; d=google.com; s=arc-20160816; b=dRrcFazRuPeU8ja2vf5+3KoNzrNjpqYBXXS4x7qThsiENd1KMTundWFSyAqnP59K05 3DZZpmf9e9WNSesHneCnqkC6FTg/P89CbV2FTPaqDw6bEONqJH+94ZkAM1XR7WtZfME5 +p/M0we9QqzxzCTj0SViJwuwJS0Wn949DnHmgy4TRF38ReQy7gujrWM/2LEmrI+StKaW Vpqg2rgNKsHLwNLWDY8LhZuLd4N1lJ9DGXdYbzWSenRH92KveiOptkgLFvM8Ymw+ap0f oqk1sG3eL1ensobkhv5PGODnptjEfEbIcmMmkxNZnBpPXN21AVtF+D6FQ2fJiRNre7ca CtBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=tqQ8hRZ398nFwgZPIA0xVWryN7yAYVgE6Ui8SyKiw+I=; b=IHq4gWaVJ7wetbQGC8vA2Xaum7zF4X47SRFbnHV7UJ2nxV5JcqagCZgv+prhww+olO o7TBOPRtAxBHCyPWREQlrHeAD+bTky0N0DFBK8HSGPYXX0Qx8JMV2hdeTKweqBP9U8/P d8i3obdA4J0i/k9ld9dGUjZpHhhYCQ32w6gMxTLOemf4l8dUD8qGf57l57TzFx4q0ihE zzZKWwXHKUZfT1JGlGMNJpwSbz30KWydzjNlvknVvdTJKOcghU1bxhF2wAXlpT07+TKo psRz/tyTwCn/lq8LuLpzf+Qcsf6bayh19QY/WRj5sRC1NqyxamY0He2MYXGB2fx9rOap fNgQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si1748309pgk.399.2019.01.17.06.35.39; Thu, 17 Jan 2019 06:35:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727536AbfAQOds (ORCPT + 99 others); Thu, 17 Jan 2019 09:33:48 -0500 Received: from muru.com ([72.249.23.125]:34020 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726008AbfAQOdr (ORCPT ); Thu, 17 Jan 2019 09:33:47 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id E80C98119; Thu, 17 Jan 2019 14:33:52 +0000 (UTC) Date: Thu, 17 Jan 2019 06:33:42 -0800 From: Tony Lindgren To: min.guo@mediatek.com Cc: Bin Liu , Rob Herring , Greg Kroah-Hartman , Mark Rutland , Matthias Brugger , Alan Stern , chunfeng.yun@mediatek.com, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, hdegoede@redhat.com, Yonglong Wu Subject: Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller Message-ID: <20190117143342.GS5544@atomide.com> References: <1547709348-17506-1-git-send-email-min.guo@mediatek.com> <1547709348-17506-5-git-send-email-min.guo@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547709348-17506-5-git-send-email-min.guo@mediatek.com> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, * min.guo@mediatek.com [190117 07:16]: > There are some quirk of MediaTek musb controller, such as: > -W1C interrupt status registers > -Private data toggle registers > -No dedicated DMA interrupt line Can you please separate the musb generic changes listed above into separate individual patches in preparation for adding support for new hardware? Otherwise we'll have hard time finding out with git bisect what exactly breaks things if we run into trouble. Regards, Tony