Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 17 Jan 2019 17:27:58 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Benjamin Gaignard <benjamin.gaignard@st.com>
Cc:     robh@kernel.org, arnd@arndb.de, linux-kernel@vger.kernel.org,
        loic.pallardy@st.com, benjamin.gaignard@linaro.org
Subject: Re: [RFC 2/7] domainsctrl: Introduce domains controller framework
Message-ID: <20190117172758.GD7003@sirena.org.uk>
References: <20190114144202.27315-1-benjamin.gaignard@st.com>
 <20190114144202.27315-3-benjamin.gaignard@st.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="W5WqUoFLvi1M7tJE"
Content-Disposition: inline
In-Reply-To: <20190114144202.27315-3-benjamin.gaignard@st.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--W5WqUoFLvi1M7tJE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 14, 2019 at 03:41:57PM +0100, Benjamin Gaignard wrote:

> Configurations could be applied with functions like
> domainsctrl_set_config_by_index() or domainsctrl_set_config_by_name().

Do you have any clients in the works for this?  It seems fairly likely
that everything is fine in terms of setting the mode but it'd be good to
confirm that's the case.  The main thing I can think of that might be a
problem here is how you'd handle a case where we were talking to another
processor that owns the permissions, we'd probably want more ways to
query state there but I'm thinking there'd likely be some other higher
level way to talk to the other processor there so perhaps it's moot.

Otherwise this all looks pretty clean and simple, there's some handling
for probe deferral in there which is the only slightly complex thing I
noticed.

--W5WqUoFLvi1M7tJE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxAux0ACgkQJNaLcl1U
h9Cjsgf+MC6ahPfTbEWy737MbALEikQaTp1QtfUFekmwX0bVdZK0VlR0EW3KqTQY
v6T/UlYbHdkM1VjKZeLPhjst6+YJ+y0rtSfqrBQuPJiuhWv9/PbMIfcvS7I1ERow
AyNBLirU80Gg1pBDwgkZm3WKG35MYos+H+445Us5W8AAXgVoHxVY9hpQ5L/R2KOG
OCaYkbavoicXGEkQIlkv2zVS6GVVBeiJ3omjXNoT+8V9moQpM+DgYqaTaoSv5IH1
CwT/Tl5YwtyS2NgxoC/rS9Bw7104bl67//dfdaXDTcI1rDCnSgN5SbRXAOVAWzPA
D37p9LF9w2LstHkhEd6R2VqDybjz+g==
=n9+8
-----END PGP SIGNATURE-----

--W5WqUoFLvi1M7tJE--