Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PATCHv2] watchdog: qcom: Add suspend/resume support
User-Agent: alot/0.8
In-Reply-To: <20190117151942.6092-1-saiprakash.ranjan@codeaurora.org>
References: <20190117151942.6092-1-saiprakash.ranjan@codeaurora.org>
Cc:     Rajendra Nayak <rnayak@codeaurora.org>,
        Vivek Gautam <vivek.gautam@codeaurora.org>,
        Sibi Sankar <sibis@codeaurora.org>,
        Doug Anderson <dianders@chromium.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-arm-msm@vger.kernel.org,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
To:     Guenter Roeck <groeck@chromium.org>,
        Guenter Roeck <linux@roeck-us.net>,
        Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>,
        Wim Van Sebroeck <wim@linux-watchdog.org>,
        linux-watchdog@vger.kernel.org
Message-ID: <154775022743.169631.1716489383315213219@swboyd.mtv.corp.google.com>
From:   Stephen Boyd <swboyd@chromium.org>
Date:   Thu, 17 Jan 2019 10:37:07 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Sai Prakash Ranjan (2019-01-17 07:19:42)
> diff --git a/drivers/watchdog/qcom-wdt.c b/drivers/watchdog/qcom-wdt.c
> index 780971318810..5dfd604477a4 100644
> --- a/drivers/watchdog/qcom-wdt.c
> +++ b/drivers/watchdog/qcom-wdt.c
> @@ -245,6 +245,28 @@ static int qcom_wdt_remove(struct platform_device *p=
dev)
>         return 0;
>  }
> =20
> +static int __maybe_unused qcom_wdt_suspend(struct device *dev)
> +{
> +       struct qcom_wdt *wdt =3D dev_get_drvdata(dev);
> +
> +       if (watchdog_active(&wdt->wdd))
> +               qcom_wdt_stop(&wdt->wdd);
> +
> +       return 0;
> +}
> +
> +static int __maybe_unused qcom_wdt_resume(struct device *dev)
> +{
> +       struct qcom_wdt *wdt =3D dev_get_drvdata(dev);
> +
> +       if (watchdog_active(&wdt->wdd))
> +               qcom_wdt_start(&wdt->wdd);
> +
> +       return 0;
> +}

This looks fairly generic. For example, the Mediatek driver also stops
and starts (but also pings after starting). Grepping for 'active' in
drivers/watchdog/ finds more examples. Could there be some functions in
watchdog core that do the common things like watchdog_stop() and
watchdog_start() and watchdog_start_and_ping()? Or maybe a bit can be
set during registration so that the 'struct class watchdog_class' can
get PM ops to stop and start on suspend/resume of the watchdog character
device?

Nothing is wrong with the patch, I'm just bemoaning the amount of code
duplication here.