Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] rtlwifi: rtl818x: fix indentation issue
To:     Joe Perches <joe@perches.com>,
        Colin King <colin.king@canonical.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        "David S . Miller" <davem@davemloft.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org
Cc:     kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
        Ping-Ke Shih <pkshih@realtek.com>
References: <20190117152859.6873-1-colin.king@canonical.com>
 <e68c7ae7b0a863742df0f4457368a3a529ed47e5.camel@perches.com>
From:   Larry Finger <Larry.Finger@lwfinger.net>
Message-ID: <284e7ef0-5820-021b-7b0c-2fc754440fe8@lwfinger.net>
Date:   Thu, 17 Jan 2019 13:33:53 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.3
MIME-Version: 1.0
In-Reply-To: <e68c7ae7b0a863742df0f4457368a3a529ed47e5.camel@perches.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/17/19 1:29 PM, Joe Perches wrote:
> On Thu, 2019-01-17 at 15:28 +0000, Colin King wrote:
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> There is a statement that is indented too deeply. Fix this.
> 
> Thanks.
> 
>> diff --git a/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c b/drivers/net/wireless/realtek/rtl818x/rtl8180/dev.c
> []
>> @@ -803,7 +803,7 @@ static void rtl8180_config_cardbus(struct ieee80211_hw *dev)
>>   		rtl818x_iowrite16(priv, FEMR_SE, 0xffff);
>>   	} else {
>>   		reg16 = rtl818x_ioread16(priv, &priv->map->FEMR);
>> -			reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>> +		reg16 |= (1 << 15) | (1 << 14) | (1 << 4);
>>   		rtl818x_iowrite16(priv, &priv->map->FEMR, reg16);
>>   	}
> 
> trivia:
> 
> It sure looks as if there could be some rather useful
> conversions of magic bits to constants one day.

How much work is warranted for this driver for a device that is not likely in 
use anywhere in the wild? In addition, I'm not sure anyone knows what those bits 
actually do, I certainly do not have a product sheet for that one.

Larry