Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2403348imu; Thu, 17 Jan 2019 13:35:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN7kBadXifnVwtRFXnpd7me60KcFkTcSZ1guueHE9ObzwJjZmginar+YJ+AuDVcWD1D0wNE1 X-Received: by 2002:a17:902:2a0a:: with SMTP id i10mr16309158plb.323.1547760940030; Thu, 17 Jan 2019 13:35:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547760939; cv=none; d=google.com; s=arc-20160816; b=q3Q6HOxuvs1DVFXeHOADjVi1LHVZJfov6wIkX/x0lTyWddewQ3De4Vit9AI355s6r0 O2vNhKTAr5Go7pabF2TOAH4RQ4QaWeFYRFVW05wvak+JYsX6Yg3V4jlQtB+kiY3uHuQd dnTzHv1ZhRkxuto/pS7vPwJZFcOMkNHD8/SbJ3vlsW7DuaB58xaZsPi3MR7hnrB3W6q0 pQtGBVSHClsycKikyPsSNou27y4ygQdYw8mgnOo5yh5GsAS4IepmH3M9f8cKH++BxxCk n5gZn/BO4ArPiJQNUJxH5brl/+ZGK/siGM3PHgPnnrOatIH4OdR+hy+nlGddfPezLmEC 8qMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=cRa9K9MKtMyR4OGRgKLP+N4UO7HLSkDOtiZhxV3KTSA=; b=LnI7TIzdGde8ZFM//QwKkljF+leAzoJcTGQuwGUBIg6xTuVMEcY1NJFdMXytUEmjkP rSiDS8c4Nkf+g+WCP/8lcrg/iPwv8e2omlyJ8Ib4mI9wo1fCiKp6q7RFA7m9BRRR+1Bh 3bpB182dLAUmWi95iVxRUCp87Jmg9OXKMotd5+uvfnIueWXE1PLwI9C9lJF4skQk+BqC CLy4S+mBOQp/Bya3ywVQ+wJ9pbEO1NltQ1Ik7bAOK5bn+Vyd0w8cXI/NUaJW78LXGuJA mfevWZhQ6OmXPcoT85wcakq630UG6k74VU85KX0fptu93hZtr7m5f5B0c+9NRcVX6UG5 Vqfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oJtNvb6q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c6si2507518plr.414.2019.01.17.13.35.21; Thu, 17 Jan 2019 13:35:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=oJtNvb6q; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729608AbfAQU6q (ORCPT + 99 others); Thu, 17 Jan 2019 15:58:46 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33477 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbfAQU6q (ORCPT ); Thu, 17 Jan 2019 15:58:46 -0500 Received: by mail-pg1-f194.google.com with SMTP id z11so4981876pgu.0; Thu, 17 Jan 2019 12:58:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=cRa9K9MKtMyR4OGRgKLP+N4UO7HLSkDOtiZhxV3KTSA=; b=oJtNvb6qgxD1flBBt4O6/GR3V3WQZTfJVczb1NhZn1aMcuyRSot2Ea0QVl3fU5kSAm sLs1hSONNTkbdffoIVdJTeZOA5cW5aZakYkdW6H6a6ZbZxaiDsA6RalHhra2O9jQ7cQC 67CLmaJbpLV9BNdJfRHA+eeTnpnt/1R/ZjqpExYkGs/LFaPzabk5+gkic04i4C21vNUC WxhzEkjNSvhyn6fFiz88qz3//vXgxEjfA3aZAWR1sAEqf7U8Z7POwzMbeWbKXwbFQ/Yl Hm+AnQDSxnPct1oY3rc8/l4DpTpbniVHWvrB+6D1QEP1ghepQ4e+SVnKUF13IZ0CezO9 RPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=cRa9K9MKtMyR4OGRgKLP+N4UO7HLSkDOtiZhxV3KTSA=; b=YXdcUJ4eGu3qQ0i2ZJ65baRuFgW1lu8rK5TserpBkPEYeqSGxLFx6X91jcJJ8xJfZS J31EvHUSw8jMAzCMfxoZeZGLUZjHlVIdU5AWj8YwNzNpoOzZc3E2/F/2WUuUk1IWWLnE YIlgY8o0KFoxeMqJBCbh3Ez7IXmsc23g+ikn6neLAxnNWKCFGIbRMHziGV3ksFDFhPG5 54txV/wYNgk9xdTmqPjDDd21RrvpuQYC5CUSCrw59Hkz+4mfy9+LMjos/mh9zCqvVk9q KQaqYDNe2M7WyGlHANC8q4J2J8Gy4qc4E1/T3zpxN0KRFnwtyp9szc7+2nhaSYO5L1Oy xEBA== X-Gm-Message-State: AJcUukck04xl46+SRUCTqPEEMr2veP0oy4KW5toA7GFGlYvxtqgmC8/Z t7TmzCv0T21F7bsKa4Cz1uW626wuJSA= X-Received: by 2002:a63:b34f:: with SMTP id x15mr15007723pgt.243.1547758724251; Thu, 17 Jan 2019 12:58:44 -0800 (PST) Received: from majic.sklembedded.com (c-73-202-231-77.hsd1.ca.comcast.net. [73.202.231.77]) by smtp.googlemail.com with ESMTPSA id h74sm4229828pfd.35.2019.01.17.12.58.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 12:58:43 -0800 (PST) From: Steve Longerbeam To: linux-media@vger.kernel.org Cc: Steve Longerbeam , stable@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Greg Kroah-Hartman , devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2] media: imx-csi: Input connections to CSI should be optional Date: Thu, 17 Jan 2019 12:58:37 -0800 Message-Id: <20190117205837.29003-1-slongerbeam@gmail.com> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some imx platforms do not have fwnode connections to all CSI input ports, and should not be treated as an error. This includes the imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0. Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode endpoint parsing will not treat an unconnected CSI input port as an error. Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier") Signed-off-by: Steve Longerbeam Reviewed-by: Philipp Zabel Acked-by: Tim Harvey Cc: stable@vger.kernel.org --- Changes in v2: - Added some acks and Cc: stable. No functional changes. --- drivers/staging/media/imx/imx-media-csi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c index 555aa45e02e3..e18f58f56dfb 100644 --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -1861,7 +1861,7 @@ static int imx_csi_parse_endpoint(struct device *dev, struct v4l2_fwnode_endpoint *vep, struct v4l2_async_subdev *asd) { - return fwnode_device_is_available(asd->match.fwnode) ? 0 : -EINVAL; + return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN; } static int imx_csi_async_register(struct csi_priv *priv) -- 2.17.1