Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190115183643.120619-1-trong@google.com> <65bb2ab8-4929-db7c-9d54-491d87ec23ae@linux.ibm.com>
In-Reply-To: <65bb2ab8-4929-db7c-9d54-491d87ec23ae@linux.ibm.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 17 Jan 2019 13:30:34 -0800
Message-ID: <CAKwvOdnkmnuNNVRx4cTUca7J7aFwzqH---+vmP8Cr3j55qaC6g@mail.gmail.com>
Subject: Re: [PATCH v2 0/4] gcov: add Clang support
To:     Peter Oberparleiter <oberpar@linux.ibm.com>,
        Tri Vo <trong@android.com>
Cc:     Greg Hackmann <ghackmann@android.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 16, 2019 at 7:17 AM Peter Oberparleiter
<oberpar@linux.ibm.com> wrote:
>
> On 15.01.2019 19:36, Tri Vo wrote:
> > From: Tri Vo <trong@android.com>
> >
> > This patch series adds Clang supoprt for gcov.
> >
> > Patch 1 refactors existing code in preparation for Clang support. Patches
> > 2-3 implement necessary LLVM runtime hooks and gcov kernel interfaces.
> > Patch 4 simplifies config selection.
> >
> > Greg Hackmann (2):
> >   gcov: clang: move common gcc code into gcc_base.c
> >   gcov: clang support
> >
> > Nick Desaulniers (1):
> >   gcov: clang: link/unlink profiling data set.
> >
> > Tri Vo (1):
> >   gcov: clang: pick GCC vs Clang format depending on compiler
>
> Overall this patch set looks good to me. It introduces a clean way for
> GCC and Clang specific implementation details to coexist.
>
> A quick test compile using GCC on s390 with the patch set applied was
> successful, so it seems like the existing support is unaffected.
>
> There are some detail suggestions on patch improvements that I'll post
> in separate e-mails.

Peter,
Thank you so much for the valuable code review and feedback.  We'll prep a v3.

Tri,
I think you should change the authorship for the patches to yourself,
and add a "Co-authored-by: " tag to the commit messages.  Can probably
squash this series into 2 patches; the one that separates out the
shared code; and the new llvm additions.  WDYT?
-- 
Thanks,
~Nick Desaulniers