Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2433395imu; Thu, 17 Jan 2019 14:12:49 -0800 (PST) X-Google-Smtp-Source: ALg8bN53VBEuBGvfYDBhbkfr+lH09bl3MY0WpuedASgKY5AAMqjen3Idb5WudjwtewiY91Iqslva X-Received: by 2002:a62:43c1:: with SMTP id l62mr17032172pfi.22.1547763169098; Thu, 17 Jan 2019 14:12:49 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547763169; cv=none; d=google.com; s=arc-20160816; b=vc8zah8rQzg80LcZi6UjV5Z7fSj+B3NJZ1i+4Ki24UIMaAafBFbSakyiWK3YDNOq0D 85/H+jET4fvt9JOx06JI3UN/Y0g+6xL5nOGD4GSWvkD9wT1iRFULM8ntmzgPqdDX9VTg QEjA2c4F5DXBamRoV70T2wMudkqsE/hcUw80yqiGVLIKU/hAUwVbkkfaBbwBtgvwMy9I tePkkwQrXyBpvc658jFwSB1qZv3cr3Br6A68nPB0INEkt8pCrISuISiwqTyyubInc7Pm jFm04r0a098giQgJvDgGGFyMDC27yZvRPl+rdaITXujCFXUN6TfjOeoSlf0k1uErrai5 xl7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:subject:user-agent:content-disposition :mime-version:message-id:cc:to:from:date; bh=LlcwmMb/BlDem58r4Qzs6DzyNoSl+DRjw+sSLAh/0aA=; b=UOb4qxjIwILOY7hg7VV9GlNrbF2fdG3uh/bytwdatZRMt/f5jaNXOppOHrF3XM+eRr 0WA0j69UqyV+OiZOPMuyi5MXRwEbYuZh+catDY7J6NQOijXlbFLHG/YE6Dz72MR/RDcY cTwpj/A7Ces3VhWEW/W6GYCSSFWFatoF6AZM4Kxkmof+9YgsdxIHKrIUeasFmhwTUhfj i8K/eHS07oPWEkwoAaKcJ+UWx3pKny6k3+N3jnLoV6K0epvLkwctEpSqBWQwVyw1hVXh 6v0H1OMMBdNED6bDrJqagCG+uA/2rSy2DE3x3j6neplibVxsyWIV83FhmHY1uAt/EFYA gCqQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si2715080pfe.52.2019.01.17.14.12.32; Thu, 17 Jan 2019 14:12:49 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728388AbfAQWK3 (ORCPT + 99 others); Thu, 17 Jan 2019 17:10:29 -0500 Received: from bout01.mta.xmission.com ([166.70.11.15]:40063 "EHLO bout01.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726898AbfAQWK2 (ORCPT ); Thu, 17 Jan 2019 17:10:28 -0500 X-Greylist: delayed 3381 seconds by postgrey-1.27 at vger.kernel.org; Thu, 17 Jan 2019 17:10:28 EST Received: from mx04.mta.xmission.com ([166.70.13.214]) by bout01.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.87) (envelope-from ) id 1gkEz5-0005TA-Uk; Thu, 17 Jan 2019 14:13:56 -0700 Received: from plesk14-shared.xmission.com ([166.70.198.161] helo=plesk14.xmission.com) by mx04.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1gkEz5-0001Wh-DM; Thu, 17 Jan 2019 14:13:55 -0700 Received: from hacktheplanet (unknown [66.244.75.217]) by plesk14.xmission.com (Postfix) with ESMTPSA id AEC64210DB9; Thu, 17 Jan 2019 21:13:54 +0000 (UTC) Date: Thu, 17 Jan 2019 16:13:52 -0500 From: Scott Bauer To: David Kozub Cc: linux-kernel@vger.kernel.org, hch@infradead.org, jonathan.derrick@intel.com, linux-block@vger.kernel.org Message-ID: <20190117211306.GA29671@hacktheplanet> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.9.4 (2018-02-28) X-XM-SPF: eid=1gkEz5-0001Wh-DM;;;mid=<20190117211306.GA29671@hacktheplanet>;;;hst=mx04.mta.xmission.com;;;ip=166.70.198.161;;;frm=sbauer@plzdonthack.me;;;spf=none X-SA-Exim-Connect-IP: 166.70.198.161 X-SA-Exim-Mail-From: sbauer@plzdonthack.me X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on sa08.xmission.com X-Spam-Level: **** X-Spam-Status: No, score=4.0 required=8.0 tests=ALL_TRUSTED,BAYES_50, DCC_CHECK_NEGATIVE,FAKE_REPLY_C,T_TM2_M_HEADER_IN_MSG,T_TooManySym_01, XMNoVowels,XMSubLong,XM_UncommonTLD01 autolearn=disabled version=3.4.2 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.4986] * 1.5 XMNoVowels Alpha-numberic number with no vowels * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa08 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject * 0.5 XM_UncommonTLD01 Less-common TLD * 1.5 FAKE_REPLY_C No description available. X-Spam-DCC: XMission; sa08 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: ****;David Kozub X-Spam-Relay-Country: X-Spam-Timing: total 289 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 4.5 (1.6%), b_tie_ro: 3.0 (1.0%), parse: 1.10 (0.4%), extract_message_metadata: 12 (4.3%), get_uri_detail_list: 0.85 (0.3%), tests_pri_-1000: 12 (4.3%), tests_pri_-950: 1.36 (0.5%), tests_pri_-900: 1.13 (0.4%), tests_pri_-90: 19 (6.7%), check_bayes: 18 (6.1%), b_tokenize: 4.1 (1.4%), b_tok_get_all: 6 (2.0%), b_comp_prob: 1.89 (0.7%), b_tok_touch_all: 3.0 (1.0%), b_finish: 0.81 (0.3%), tests_pri_0: 225 (78.0%), check_dkim_signature: 0.42 (0.1%), check_dkim_adsp: 3.3 (1.2%), poll_dns_idle: 0.92 (0.3%), tests_pri_10: 2.1 (0.7%), tests_pri_500: 6 (2.2%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH 00/16] block: sed-opal: support shadow MBR done flag and write X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on mx04.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 09:56:51PM +0000, David Kozub wrote: > block: sed-opal: rename next to execute_steps I don't see this change anywhere on the lists. I have 0->15, but am missing 16/16. Please resend v2 with the changes Christoph requested, so it's easier to review. Lastly, please CC me on the changes, and I will review them: sbauer@plzdonthack.me I don't work at Intel anymore -- maintainers never got updated. > Jonas Rabenstein (8): > block: sed-opal: use correct macro for method length > block: sed-opal: unify space check in add_token_* > block: sed-opal: print failed function address > block: sed-opal: split generation of bytestring header and content > block: sed-opal: add ioctl for done-mark of shadow mbr > block: sed-opal: ioctl for writing to shadow mbr > block: sed-opal: unify retrieval of table columns > block: sed-opal: check size of shadow mbr > > block/opal_proto.h | 18 + > block/sed-opal.c | 843 +++++++++++++++++----------------- > include/linux/sed-opal.h | 2 + > include/uapi/linux/sed-opal.h | 9 + > 4 files changed, 449 insertions(+), 423 deletions(-) > > -- > 2.20.1