Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190115183643.120619-1-trong@google.com> <20190115183643.120619-5-trong@google.com>
 <CAKwvOdkUMpqu3_2bC1DJ47JKg-YVDZDbUOwu63uGkH+wvxA=cg@mail.gmail.com> <CAK7LNAQXY-hU+dvgRM15zRKu-noK=esQu+85uASYFPC5UwfnhA@mail.gmail.com>
In-Reply-To: <CAK7LNAQXY-hU+dvgRM15zRKu-noK=esQu+85uASYFPC5UwfnhA@mail.gmail.com>
From:   Nick Desaulniers <ndesaulniers@google.com>
Date:   Thu, 17 Jan 2019 13:48:44 -0800
Message-ID: <CAKwvOdmji0RC6Whrr5y2mcsEQhw_VA619607xAhK+XTZ5JSWVA@mail.gmail.com>
Subject: Re: [PATCH v2 4/4] gcov: clang: pick GCC vs Clang format depending on compiler
To:     Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     Tri Vo <trong@android.com>,
        Peter Oberparleiter <oberpar@linux.ibm.com>,
        Greg Hackmann <ghackmann@android.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-team@android.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 16, 2019 at 2:19 AM Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> > I think this was the suggestion from Masahiro from v1?
>
> Yes.
>
>
> What is strange is, 2/4 added GCOV_FORMAT_CLANG,
> then 4/4 deletes it.
>
>
> Probably, changing the patch order,
> or squashing 4/4 into 2/4 would be cleaner.

Sure; Tri, I think it's ok for you to become author of 2/4 and put a
"Co-authored-by:" tag for Greg.

-- 
Thanks,
~Nick Desaulniers