Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] media: imx-csi: Input connections to CSI should be
 optional
To:     Tim Harvey <tharvey@gateworks.com>
Cc:     linux-media <linux-media@vger.kernel.org>,
        Philipp Zabel <p.zabel@pengutronix.de>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20190109183448.20923-1-slongerbeam@gmail.com>
 <CAJ+vNU1dByOE8QM4Y0R0z9sSgvb6_73_xTyRiOZL4LXb9BgR3w@mail.gmail.com>
From:   Steve Longerbeam <slongerbeam@gmail.com>
Message-ID: <be53ba69-9ad3-80c1-d7f7-d2ff40c48e2b@gmail.com>
Date:   Thu, 17 Jan 2019 12:53:06 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CAJ+vNU1dByOE8QM4Y0R0z9sSgvb6_73_xTyRiOZL4LXb9BgR3w@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Tim,

On 1/15/19 8:42 AM, Tim Harvey wrote:
> On Wed, Jan 9, 2019 at 10:34 AM Steve Longerbeam <slongerbeam@gmail.com> wrote:
>> Some imx platforms do not have fwnode connections to all CSI input
>> ports, and should not be treated as an error. This includes the
>> imx6q SabreAuto, which has no connections to ipu1_csi1 and ipu2_csi0.
>> Return -ENOTCONN in imx_csi_parse_endpoint() so that v4l2-fwnode
>> endpoint parsing will not treat an unconnected CSI input port as
>> an error.
>>
>> Fixes: c893500a16baf ("media: imx: csi: Register a subdev notifier")
>>
>> Signed-off-by: Steve Longerbeam <slongerbeam@gmail.com>
>> ---
>>   drivers/staging/media/imx/imx-media-csi.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/staging/media/imx/imx-media-csi.c b/drivers/staging/media/imx/imx-media-csi.c
>> index 4223f8d418ae..30b1717982ae 100644
>> --- a/drivers/staging/media/imx/imx-media-csi.c
>> +++ b/drivers/staging/media/imx/imx-media-csi.c
>> @@ -1787,7 +1787,7 @@ static int imx_csi_parse_endpoint(struct device *dev,
>>                                    struct v4l2_fwnode_endpoint *vep,
>>                                    struct v4l2_async_subdev *asd)
>>   {
>> -       return fwnode_device_is_available(asd->match.fwnode) ? 0 : -EINVAL;
>> +       return fwnode_device_is_available(asd->match.fwnode) ? 0 : -ENOTCONN;
>>   }
>>
>>   static int imx_csi_async_register(struct csi_priv *priv)
>> --
>> 2.17.1
>>
> Steve,
>
> Thanks, this fixes adv7180 the capture regression on the Gateworks
> Ventana boards as well. This should go to stable to fix 4.20 so please
> add a 'Cc: stable@vger.kernel.org' if you re-submit (else we can send
> it to stable@vger.kernel.org later).
>
> Acked-by: Tim Harvey <tharvey@gateworks.com>

I will resubmit a non-functional v2 that adds the Cc: stable and your ack.

Steve