Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Ran Wang <ran.wang_1@nxp.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/3] usb: ehci: fsl: Update register accessing for
 arm/arm64 platforms
Thread-Topic: [PATCH v2 1/3] usb: ehci: fsl: Update register accessing for
 arm/arm64 platforms
Thread-Index: AQHUrkSK5gjXIA2AjUOFpVeBl/CheKWzoS2AgACr9oA=
Date:   Fri, 18 Jan 2019 02:39:57 +0000
Message-ID: <AM5PR0402MB28658F89C6853D65BB381DB4F19C0@AM5PR0402MB2865.eurprd04.prod.outlook.com>
References: <20190117091135.44209-1-ran.wang_1@nxp.com>
 <Pine.LNX.4.44L0.1901171107150.1207-100000@iolanthe.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1901171107150.1207-100000@iolanthe.rowland.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: de1ad6b5-bf1d-417c-306d-08d67cee3c9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Jan 2019 02:39:57.9271
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0402MB2820
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Alan,

On January 18, 2019 00:08, Alan Stern wrote:
>=20
> On Thu, 17 Jan 2019, Ran Wang wrote:
>=20
> > arm/arm64's io.h doesn't define clrbits32() and clrsetbits_be32(),
> > which causing compile failure on some Layerscape Platforms (such as
> > LS1021A and LS2012A which also integrates FSL EHCI controller). So use
> > ioread32be()/iowrite32be() instead to make it workable on both powerpc
> > and arm.
>=20
> For patches 1/3 and 3/3:
>=20
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
>=20
> Have you tested these on the Layerscape platforms to make sure they work
> correctly?

To be honest, the first goal of this patch set is to fix compile issue.=20
And I have verified it on LS1012AQDS, and encountered failure as below:

[    2.966755] ehci-fsl: Freescale EHCI Host controller driver
[    2.973113] fsl-ehci fsl-ehci.0: Freescale On-Chip EHCI Host Controller
[    2.979851] fsl-ehci fsl-ehci.0: new USB bus registered, assigned bus nu=
mber 3
[    2.987549] fsl-ehci fsl-ehci.0: irq 22, io mem 0x08600000
[    3.005769] fsl-ehci fsl-ehci.0: USB 2.0 started, EHCI 0.00
[    3.012122] hub 3-0:1.0: USB hub found
[    3.016088] hub 3-0:1.0: config failed, hub doesn't have any ports! (err=
 -19)

However, actually the only board which I can find so far has known HW issue=
 on
EHCI part, so I plan to find other platform to do complete verification whe=
n
possible. And will submit other fix if needed. Is that OK?

BTW, for powerpc platform, I've tested on a T1042AD4RDB and USB worked fine=
 with it.

Regards,
Ran