Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2744657imu; Thu, 17 Jan 2019 21:34:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN6p3Bh7NykegDau2eAmeib8uQhECiLdCXaAL2lNU1XL/Gv60cP7842zhRBW0bVvV0/mY2cp X-Received: by 2002:a62:cec6:: with SMTP id y189mr18595757pfg.100.1547789693150; Thu, 17 Jan 2019 21:34:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547789693; cv=none; d=google.com; s=arc-20160816; b=L3RQ3/UKRVU5Ud71wgd5KHNPCgqY0uAl4S7caDQpGCI7zaNL4LVoyZzwJgukPi7ane Z7aRazr9aJ4mDa1FA+IOAtBVuRElEWcUHfWPirCNyvodUr+VbQ57Rpp8ymBgOWvwxX6F Jty+GdVhQiN32tqeBbrgCgw34C3X1MN5yiA8JrRTtXE1blhnmnaRMJu2XHtDWgj5Sy8w hOFxQDpYb2vPR/Sl3OWPVEdbCK27tm2lln2Z0FCkD5wanwgx3LqS7LyxD0s71Lx/KIXV S0wdt/6GCJkFB3oJXGdKmuAH9zl6CzeJ0dLw15/7QozOMVUdJ1QDOVWxEuKOBWxLIY6G gePA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=g0IEtR2LdGStw2ATPKCXJNsCFAJuQAUZId86SAXzF9Y=; b=SGyKobyGi/8PLXJ3P9zho5s706aplfCykGqjyNc4mMgsYjkk0c7iHMpQ66ayk0noV1 CFIbxba6qRwBTc/Ldog07cgC6QN8sVnKXLRRMxXh8zQbFS3NedHMuntCnyG/jqlh0d4z c256a+uySbcfvm9NhzcQGNSEfZhUeXgntD7htpn/r+QH+0of3AfECp5jN+tjRVxsTb8Q 4hv0/jTnD+wKXuqYiixkFZFVsaoox2fEUXMaKFqNKv2htugnJP9TAqrl0oKaamrhCLUb bnwlNF9Zdw2ZpJx60jKOmcVRJybUIcgEn3J3SoIOnkXxcV4WW2zEjLWsZ0zs+YxB6UA3 Lrwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=IqUYVyYC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u91si3924542plb.237.2019.01.17.21.34.20; Thu, 17 Jan 2019 21:34:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nifty.com header.s=dec2015msa header.b=IqUYVyYC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727099AbfARFcJ (ORCPT + 99 others); Fri, 18 Jan 2019 00:32:09 -0500 Received: from conuserg-12.nifty.com ([210.131.2.79]:51524 "EHLO conuserg-12.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726401AbfARFcJ (ORCPT ); Fri, 18 Jan 2019 00:32:09 -0500 Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id x0I5Uo9J016515; Fri, 18 Jan 2019 14:30:51 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com x0I5Uo9J016515 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1547789451; bh=g0IEtR2LdGStw2ATPKCXJNsCFAJuQAUZId86SAXzF9Y=; h=From:To:Cc:Subject:Date:From; b=IqUYVyYCr2u20fWkbOsEFg9rWXO45lPD/7NZ5UyxX3zUB5d6Wr1rX3dhXZm9TsiaO 8jLl2EttACDLk+qZkF46YSf9gXnrGhgsNovK6ieRKHlNOJajkP8yNKuiKI4rPdcBc5 G1mLUyJkzyhTn5E+vKr/3+zDm6GRDR0NrN4wfaiAp5lNjIgp+yMl2ZKonhJDDT0Ram 18s1YQ8TZfLJonk5R1JZEgaZbU+H08gDnbziyr2mISmqQPaguirWfrLIq6RV9XLFqz uBTI0uXOrY5eGLUZaOBHvs9r7g+IIMQx2jrm4GNxuS9YQrnVJK6xvLgUYXkJQalSHh K2BHRUocjcj9w== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: linux-mtd@lists.infradead.org, Boris Brezillon , Miquel Raynal Cc: Masahiro Yamada , "linux-stable # v4 . 20" , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Date: Fri, 18 Jan 2019 14:30:38 +0900 Message-Id: <1547789438-11899-1-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops") missed to invert the if-conditonal for denali. Since then, the Denali NAND driver cannnot invoke setup_data_interface. Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops") Cc: linux-stable # v4.20 Signed-off-by: Masahiro Yamada --- drivers/mtd/nand/raw/denali.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/raw/denali.c b/drivers/mtd/nand/raw/denali.c index eebac35..6e8edc9 100644 --- a/drivers/mtd/nand/raw/denali.c +++ b/drivers/mtd/nand/raw/denali.c @@ -1322,7 +1322,7 @@ int denali_init(struct denali_nand_info *denali) } /* clk rate info is needed for setup_data_interface */ - if (denali->clk_rate && denali->clk_x_rate) + if (!denali->clk_rate || !denali->clk_x_rate) chip->options |= NAND_KEEP_TIMINGS; chip->legacy.dummy_controller.ops = &denali_controller_ops; -- 2.7.4