Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 0/5] drm/bridge: various small lvds-encoder things
To:     Peter Rosin <peda@axentia.se>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc:     David Airlie <airlied@linux.ie>, Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Archit Taneja <architt@codeaurora.org>,
        Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
From:   Andrzej Hajda <a.hajda@samsung.com>
Message-ID: <be258481-b3e4-8051-abb2-ca430ecc2836@samsung.com>
Date:   Fri, 18 Jan 2019 09:43:16 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
        Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20190111151843.11114-1-peda@axentia.se>
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 201P
References: <CGME20190115040858epcas3p4b4b9bfa6f6706842ad92825fea36d59e@epcas3p4.samsung.com>
        <20190111151843.11114-1-peda@axentia.se>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 11.01.2019 16:18, Peter Rosin wrote:
> Hi!
>
> I'm not sure if I should have added the texas chips to the lvds_encoder_match
> list in the driver, right next to the thine,thc63lvdm83d entry, but ended
> up not doing that. That can always be added later, if needed...
>
> Changes since v3:
> - retained a (modified) note in lvds-transmitter.txt about encoders with
>   additional device-specific properties
> - added tag from Rob on patch 3/5
>
> Changes since v2:
> - changed from pwdn-gpios to powerdown-gpios after discussion with Rob with
>   new patch 3/5 updating the thine,thc63lvdm83d binding as well as a
>   consequence
> - added patch 4/5 which helps keep lines shorter in the lvds-encoder driver
> - added tag from Rob on patch 2/5
>
> Changes since v1:
> - fork out the bindings for the texas chips into their own file in order
>   to avoid clutter in the generic lvds-transmitter binding.
> - added a patch to remove some surplus stuff in the generic lvds-transmitter
>   binding.
>
> Cheers,
> Peter


Queued to drm-misc-next.


One thing I have spotted after merging is that there no need to
null-check before gpiod_set_value_cansleep, no big deal, I guess.


Regards

Andrzej


>
> Peter Rosin (5):
>   dt-bindings: display: bridge: fork out ti,ds90c185 from
>     lvds-transmitter
>   dt-bindings: display: bridge: lvds-transmitter: cleanup example
>   dt-bindings: display: bridge: thc63lvdm83d: use standard
>     powerdown-gpios
>   drm/bridge: lvds-encoder: add dev helper variable in .probe()
>   drm/bridge: lvds-encoder: add powerdown-gpios support
>
>  .../bindings/display/bridge/lvds-transmitter.txt   | 12 ++---
>  .../bindings/display/bridge/thine,thc63lvdm83d.txt |  2 +-
>  .../bindings/display/bridge/ti,ds90c185.txt        | 55 ++++++++++++++++++++++
>  drivers/gpu/drm/bridge/lvds-encoder.c              | 53 +++++++++++++++++----
>  4 files changed, 103 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ds90c185.txt
>