Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2891877imu; Fri, 18 Jan 2019 00:54:26 -0800 (PST) X-Google-Smtp-Source: ALg8bN6QQ+4G7W8vtcy4Zcppau6Gpb8Yu3ZXtjovHyT+QrSBOi7W7xyh35d+5pokpjlyq52PbvWk X-Received: by 2002:a63:2f07:: with SMTP id v7mr15832567pgv.368.1547801666487; Fri, 18 Jan 2019 00:54:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547801666; cv=none; d=google.com; s=arc-20160816; b=DQISgRmMNTPGmLx0OYk2YWc9mi7bhzLorwPRLxPcLkwmP+f+RyDE43iE9je1k081vG KLh4KsF0j4dI07+z3Cqc+CJqdybruTob4YCWK6k+Mwom+Q1FlYfN9F/awAWtPybE4Agq AMKmGI+RVPAcLirnjDJ/5OpT8xyMC1pcTWOoDT09ijJncBwpQD3XOg4ukeTOnWuViNk8 W3/xWZxuQkdWftBISjAVOieNMImimtjYD7A0E2dTdx3fQXlmsI4Y+x1S5aOy1I/rcC6Z CNRYRY6Hv3jCL4fAAmiHcqc3cYqLS9IhThc1lKSD8FOVD4geKpX8d8DCM7Pl06dMNjJt LDhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=rSFQovaNBFa28qwmGwODA7iYeFwNywuPtIKpRRAWa8I=; b=NOxA5KRsyh0HCrRY+RghGliL8ACu60qbJVCdg6l0s0WDUwKcjI1wY2It6Nt/ZEKtRj 07YyOrt5IGtZ53Y/7X6Cj+7jRhhCdcydEjkgcJ9piWKwM0Jr2z3sMlBHGuT8Za9cg8uN mnyJPxROxdClIHRlSvAYrslJ7rmXa82PnAUilSylgXjGt7HXoXb6RMSns5Wit/79V+QC GM5xnmuswNfGLt0b+fFQu7hOEGKIA0TFR9pjPtjXRajkoBj/Allm2i8Bl1+TWoCls24K s1TndLNa9ECYbGMldyqSTF3h7YblKQL2Oe3VxnxokKBvB8zbyh25Bqbs5tc5C3Z14wyg 0rJg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si3710037plr.144.2019.01.18.00.54.08; Fri, 18 Jan 2019 00:54:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbfARIwe convert rfc822-to-8bit (ORCPT + 99 others); Fri, 18 Jan 2019 03:52:34 -0500 Received: from mail.bootlin.com ([62.4.15.54]:35063 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727533AbfARIwd (ORCPT ); Fri, 18 Jan 2019 03:52:33 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 28405207AC; Fri, 18 Jan 2019 09:52:31 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (aaubervilliers-681-1-37-87.w90-88.abo.wanadoo.fr [90.88.156.87]) by mail.bootlin.com (Postfix) with ESMTPSA id CE625206DC; Fri, 18 Jan 2019 09:52:30 +0100 (CET) Date: Fri, 18 Jan 2019 09:52:30 +0100 From: Miquel Raynal To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Boris Brezillon , "linux-stable # v4 . 20" , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: Re: [PATCH] mtd: rawnand: denali: get ->setup_data_interface() working again Message-ID: <20190118095230.5f097e9e@xps13> In-Reply-To: <1547789438-11899-1-git-send-email-yamada.masahiro@socionext.com> References: <1547789438-11899-1-git-send-email-yamada.masahiro@socionext.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Masahiro Yamada wrote on Fri, 18 Jan 2019 14:30:38 +0900: > Commit 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to > nand_controller_ops") missed to invert the if-conditonal for denali. > Since then, the Denali NAND driver cannnot invoke setup_data_interface. > > Fixes: 7a08dbaedd36 ("mtd: rawnand: Move ->setup_data_interface() to nand_controller_ops") > Cc: linux-stable # v4.20 > Signed-off-by: Masahiro Yamada > --- > Acked-by: Miquel Raynal Thanks, Miquèl