Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2946456imu; Fri, 18 Jan 2019 02:02:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN5J8XUsT3cAo48qwemx+aCwpfF+wAHrW7vWE0AG99qbYb7bnJV9myknTriN+7u7GP5+Li6U X-Received: by 2002:a62:1e87:: with SMTP id e129mr18614392pfe.221.1547805725217; Fri, 18 Jan 2019 02:02:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547805725; cv=none; d=google.com; s=arc-20160816; b=IDGdQU4hnCCjKM0fI2bqxKbn7+BxC4knCnnoiWuCmjfuaKu4ojUdc+He+p1RkE6X1/ ftXIV73ZAtR+UK1UCXTrBCaAGFU2ebNYHXCCsPEXg7276r0Ki1T+REW8t7r+8Yisp1BZ 7ceeeJy7CvVi85j0QGQRCcQTUVD5eP05GPwQqNJvH+ijwjNbXZsKOsiW+Hh2/H2fA5jb /8M1xIQR6pep048QFhsMmRZeAgdxj3Ez0d5jeVYylVl8k9r4od13NRTdA7FE/iptkk7k VwUQJAJwvDtyFu8EL+RryFQgHaPz8AiGFiIfPJlxUeLxPpLne9QyHjjdGLEPSBHoz25r cs5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=8bKVbgwfeYYFdltnA5x4XA9pSZrt9lQlb2uhtHuBv0Q=; b=RyvhRpF05qPFrflh4zkgQENOeWANGtyID0l2yWMZWhGU5qMaTNTZJWpTqEf08auSd7 Kdu2jQ+0XLAqB4gshf12pUBuFqAmnHQ5ga3qCybLJuqM+1mfaRELhida5v8aoIIggfuY Gx4WoueD3lEqvbyJNgMe+fjPvVHO9SGfOT4lwiuRM/a8Jt1f6z7eR4C+HX7cmg7KobHf /v9FmbHmOvLe4la3pyDkJ2r2EyddeOppjbWcQwLE+qLT25xqhSRYynhGIYJnlPgK3Lo7 UG7+rCQMihDRi2qLKufO/x46esHvXQQuiCVMqaHHlLSmlLdUFv+ybKbXx/hYB/VGV9px Rd5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yf1jjm/V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e3si4496928pfe.203.2019.01.18.02.01.46; Fri, 18 Jan 2019 02:02:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yf1jjm/V"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726732AbfARJ7N (ORCPT + 99 others); Fri, 18 Jan 2019 04:59:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:43904 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbfARJ7M (ORCPT ); Fri, 18 Jan 2019 04:59:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8F09120855; Fri, 18 Jan 2019 09:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1547805552; bh=bi79GgZoAuKaprmqKXHTzgLH9/5j+h1IjVoIMgE+fvw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yf1jjm/VFkQ5nG+rjeQM3LZqHdV2MjPVlMO5L1C8RLkJ1Ub6DAkbaKCug3O1oe5jl CF1r4vuVYR0tR0FBAtfAV/utPjX7k3BITbE5DR2T0IELiyh2xzHnsg8BHlUyJLlxnK 53klqVavymDn+Lj5/vlLk7lkEyR2beeG8GHGkm/I= Date: Fri, 18 Jan 2019 10:59:09 +0100 From: Greg Kroah-Hartman To: "Andrew F. Davis" Cc: Laura Abbott , Sumit Semwal , Arve =?iso-8859-1?B?SGr4bm5lduVn?= , devel@driverdev.osuosl.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 12/14] staging: android: ion: Declare helpers for carveout and chunk heaps Message-ID: <20190118095909.GB28982@kroah.com> References: <20190111180523.27862-1-afd@ti.com> <20190111180523.27862-13-afd@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190111180523.27862-13-afd@ti.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 11, 2019 at 12:05:21PM -0600, Andrew F. Davis wrote: > When enabled the helpers functions for creating carveout and chunk heaps > should have declarations in the ION header. Why? No one calls these from what I can tell. Which makes me believe we should just delete the drivers/staging/android/ion/ion_carveout_heap.c and drivers/staging/android/ion/ion_chunk_heap.c files as there are no in-tree users? Any objection to me doing that? thanks, greg k-h