Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3068569imu; Fri, 18 Jan 2019 04:20:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN76RjD56I2dVMEI/ezLMveA4BOgfgsImwCkUQGgsW2NgSFBn4PX58emft7v5aAgg04hW0i5 X-Received: by 2002:a62:7504:: with SMTP id q4mr18812373pfc.180.1547814052631; Fri, 18 Jan 2019 04:20:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547814052; cv=none; d=google.com; s=arc-20160816; b=MK6cQEUTEDJqUkkR+0t9imaKgIlIuX7oAN5TknzbfW/WUmx006v/oQAlGc3cmnix8n Gc0r4EZHqs7AIhMc+o+IVy2/n0j4fTD7jp82y9J1PDoODGsbK24WNg3BzKDx5UgutH2I P2fHQ8Xca88DuofMShTIObsUSYe5Q0Ic4F9FQ5LMwR7hJnsGcU6VCp/ObGTc8Toh20SS cVTffj7skmxUilq70D3DUFKPYibgxNa7mpz+z1biWDb4XZHlt5k1/vxc3YNZL6VKQ3kX Ef6uiu4buB2YoRN7ah3Quo9cekSaa7HuSPIZWy6gSVaQXiCP20kq86AmgdNKkt6jEAlS Niog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=xcFuBeCX/Fucgt6nz4soleJ7V1rAMoPtKhU309chEjs=; b=BhpD/upWleFbb+udVwpRaWmDCeXgDbTWJGIJNOJtAK4evpKpXpUCZ01kIgP0YwvCBF u0pxrPjSIFuwlNr9X80NV8U0H7q8YbhoDMvlKTXO99I8WbZWVxTWcfmwK2bIVWBLsItG 58fEMq8ugkblIhZZTYPtT6OjIbNSQt9PIlomVi5kUfyGVrjDZZ2NUNwIEi7+dSUQ/+wo WauAP615/p6lxVWXY+UZaJCeDjGoGjAQDCjLEZhB29pj965h8bFkfOMdO5ugeen0ouCW gsuPF31IGCMlQ4fE0w4EkP68AwPuC5zuoanohdr+Zl4vSdJqZo1oiGq3AyTEHTNjMxvg /lZw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h69si4371274pge.121.2019.01.18.04.20.32; Fri, 18 Jan 2019 04:20:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727471AbfARMSM (ORCPT + 99 others); Fri, 18 Jan 2019 07:18:12 -0500 Received: from verein.lst.de ([213.95.11.211]:43259 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727212AbfARMSM (ORCPT ); Fri, 18 Jan 2019 07:18:12 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 54BFE68CEB; Fri, 18 Jan 2019 13:18:10 +0100 (CET) Date: Fri, 18 Jan 2019 13:18:10 +0100 From: Christoph Hellwig To: Christian Zigotzky Cc: Christoph Hellwig , linux-arch@vger.kernel.org, Darren Stevens , linux-kernel@vger.kernel.org, Julian Margetson , linux-mm@kvack.org, iommu@lists.linux-foundation.org, Paul Mackerras , Olof Johansson , linuxppc-dev@lists.ozlabs.org Subject: Re: use generic DMA mapping code in powerpc V4 Message-ID: <20190118121810.GA13327@lst.de> References: <21f72a6a-9095-7034-f169-95e876228b2a@xenosoft.de> <27148ac2-2a92-5536-d886-2c0971ab43d9@xenosoft.de> <20190115133558.GA29225@lst.de> <685f0c06-af1b-0bec-ac03-f9bf1f7a2b35@xenosoft.de> <20190115151732.GA2325@lst.de> <20190118083539.GA30479@lst.de> <871403f2-fa7d-de15-89eb-070432e15c69@xenosoft.de> <20190118112842.GA9115@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jan 18, 2019 at 01:07:54PM +0100, Christian Zigotzky wrote: > git clone git://git.infradead.org/users/hch/misc.git -b powerpc-dma.6 a > > git checkout 257002094bc5935dd63207a380d9698ab81f0775 > > > I get the following error message with your patch: Hmm. Did I attached the wrong patch? Here is the one I want and just applied to that revision: diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c index 355d16acee6d..e46c9b64ec0d 100644 --- a/kernel/dma/direct.c +++ b/kernel/dma/direct.c @@ -118,8 +118,11 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, page = NULL; } } - if (!page) + if (!page) { page = alloc_pages_node(dev_to_node(dev), gfp, page_order); + if (!page) + pr_warn("failed to allocate memory with gfp 0x%x\n", gfp); + } if (page && !dma_coherent_ok(dev, page_to_phys(page), size)) { __free_pages(page, page_order); @@ -139,6 +142,10 @@ struct page *__dma_direct_alloc_pages(struct device *dev, size_t size, } } + if (!page) { + pr_warn("failed to allocate DMA memory!\n"); + dump_stack(); + } return page; }