Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3101266imu; Fri, 18 Jan 2019 04:57:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN7VMUD5YZUOteV90b3jfWG90HQ1VjSj6prG45v1i+4OJh16M1FWtJ89C2nluSc0rmWIGuvQ X-Received: by 2002:a17:902:201:: with SMTP id 1mr18959666plc.62.1547816268222; Fri, 18 Jan 2019 04:57:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547816268; cv=none; d=google.com; s=arc-20160816; b=qKpjmOAvEhkzdyshqTikS9MwANz6DpssOgTBmxvs75oFNeg6zDDS1sFujpZ8ZfP1AA lmmKM/lHacTKJZ87ZLF7+1AQpZYMyZ0flmG+chEqQILnPUWbQS0nisIwzoolEZVeTeal abM5V4/U6F36kg7OX2hGyY+XBiHpjRsiKHdNq2hcnb4kpPAebrimjdco3XQoPvOiD2Y3 9qumTPT1xNEqnoUcDTv4uaXx0FSak+3vjxcoyf+aTyB10w+cdkHmlfZpZT/frKSL0td/ At7WXWtcMa3/3EMO0XANy6wJV3dvqWbE2OFh8WMtd8B42CfChaSy3LHeSFF3tUGT6VyB YCeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=3sG7OW1OYoA862WFpuBhQaQvpPEZfIvVz7qnFiyJYoM=; b=IuM1IqVd8u0jWZWU4tkwHbWxLvhbwEa3GXl/SXNYzIWzrkHvUx4BHmxyI0KizR4bPi ftveTNAtRPKRFBC9K2hX7BUlO0czBxix8FN/Ndh7mMSAWcecooIGIIO9d1jSbGkhLNC2 CvnhPHjtBX2lxNGRYRZNK0Kptd4J9fnTMrVtH1ZQoGkZyLM1Wy9fC2fDku6XtMlcjH+/ +peKje4sXRAus17riC0yQGJIPFcu7+XCiKa2ODudyXvGGCJYuKNTvVcqCcqOY+feXyve sFVqu/BVCLqiRMaXUuWDK7l7DA/uQxnYzAbf+HI3q9FXpG5DZbhezM3hKjcR5Bq+mGSv LOLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=fJNMA9M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 36si4525567pgt.213.2019.01.18.04.57.30; Fri, 18 Jan 2019 04:57:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=fJNMA9M1; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727819AbfARMz4 (ORCPT + 99 others); Fri, 18 Jan 2019 07:55:56 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:51696 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726062AbfARMzz (ORCPT ); Fri, 18 Jan 2019 07:55:55 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id x0ICtmxA029338; Fri, 18 Jan 2019 06:55:48 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1547816148; bh=3sG7OW1OYoA862WFpuBhQaQvpPEZfIvVz7qnFiyJYoM=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=fJNMA9M1Pl6MgBK2Phm3hPXNKUW9lktMZhPF+ikUAXXYYPg2L+1fGLMtRbO6IvI9T gdDOSwh5uSBRzxBrViHbGQS+GWEG1OmLJWFvlgLlstQkmUSM1szPg+T9ZN789tB8Dj yUkp3sL/Yjwe4FQEMs9ABnunPIZ+lNCh9c6Q2NZU= Received: from DFLE105.ent.ti.com (dfle105.ent.ti.com [10.64.6.26]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id x0ICtlZY015237 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 18 Jan 2019 06:55:48 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Fri, 18 Jan 2019 06:55:47 -0600 Received: from dflp33.itg.ti.com (10.64.6.16) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1591.10 via Frontend Transport; Fri, 18 Jan 2019 06:55:47 -0600 Received: from [172.22.105.109] (ileax41-snat.itg.ti.com [10.172.224.153]) by dflp33.itg.ti.com (8.14.3/8.13.8) with ESMTP id x0ICtlZc001129; Fri, 18 Jan 2019 06:55:47 -0600 Subject: Re: [PATCH v4 1/4] can: m_can: Create a m_can platform framework To: Wolfgang Grandegger , , CC: , , References: <20190117200601.16416-1-dmurphy@ti.com> <641ae2ce-def9-6032-b8dc-cc71311bc993@grandegger.com> From: Dan Murphy Message-ID: <82d9f82c-1da6-2374-062b-538840afcc44@ti.com> Date: Fri, 18 Jan 2019 06:55:28 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <641ae2ce-def9-6032-b8dc-cc71311bc993@grandegger.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfgang On 1/18/19 12:56 AM, Wolfgang Grandegger wrote: > Hello Dan, > > Am 17.01.19 um 21:08 schrieb Dan Murphy: >> Wolfgang >> >> On 1/17/19 2:05 PM, Dan Murphy wrote: >>> Create a m_can platform framework that peripherial >>> devices can register to and use common code and register sets. >>> The peripherial devices may provide read/write and configuration >>> support of the IP. >>> >>> Signed-off-by: Dan Murphy >>> --- >>> drivers/net/can/m_can/m_can.c | 6 + >>> drivers/net/can/m_can/m_can_platform.c | 209 +++++++++++++++++++++++++ >>> drivers/net/can/m_can/m_can_platform.h | 163 +++++++++++++++++++ >>> 3 files changed, 378 insertions(+) >>> create mode 100644 drivers/net/can/m_can/m_can_platform.c >>> create mode 100644 drivers/net/can/m_can/m_can_platform.h >>> > > ... snip ... > >> This patch set is working for the TCAN and at least boots on io-mapped devices. >> We have a couple of customers who are looking at using this implementation and we would like to >> start moving this patch set along in the review. >> >> I did not put a change log in here as there have been no comments for the last 3 patch sets I sent. >> >> This v4 squashes a few bugs I found during testing across all the files. > > OK, after a very busy week I will try to find time for the review... > finally. > Thanks. I anticipate a v5 as we debug the io mapped code and continue to test the TCAN code. Dan > Thanks, > > Wolfgang. > -- ------------------ Dan Murphy