Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 18 Jan 2019 16:55:41 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Wei Yang <richardw.yang@linux.intel.com>
Cc:     linux-kernel@vger.kernel.org, rafael@kernel.org
Subject: Re: [PATCH v2] driver core: move device->knode_class to
 device_private
Message-ID: <20190118155541.GA5544@kroah.com>
References: <20190117055719.6161-1-richardw.yang@linux.intel.com>
 <20190118023459.9972-1-richardw.yang@linux.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190118023459.9972-1-richardw.yang@linux.intel.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 18, 2019 at 10:34:59AM +0800, Wei Yang wrote:
> As the description of struct device_private says, it stores data which
> is private to driver core. And it already has similar fields like:
> knode_parent, knode_driver, knode_driver and knode_bus. This look it is
> more proper to put knode_class together with those fields to make it
> private to driver core.
> 
> This patch move device->knode_class to device_private to make it comply
> with code convention.
> 
> Signed-off-by: Wei Yang <richardw.yang@linux.intel.com>
> Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Thanks for this.  There are a number of other variables that should move
into this structure, if you want to take a look into doing that.

greg k-h