Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp3610219imu; Fri, 18 Jan 2019 13:32:08 -0800 (PST) X-Google-Smtp-Source: ALg8bN6y+eMny7BetNOUggrRlFj6xD0dp0BQ2YsNnFuHOqiFj5CwNdkTuRntduwW1F5Zzcshr+u0 X-Received: by 2002:a62:3888:: with SMTP id f130mr20645016pfa.132.1547847128542; Fri, 18 Jan 2019 13:32:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547847128; cv=none; d=google.com; s=arc-20160816; b=oyq2CBt0qG9oNO9Iv1y99mum+d/3ocrQDhrTr+4NyO48ZfRBNpKPVoPaI9vYVJtC82 noDzPvjmdz+alESbw1N8ahW2FUcBsJmgvvlnMmA8jgC5pZCzZNE4Wj6rRs5w9aIt/knk EgsyL3cH7M20HBPC3NQhM7xTw8+zEXfuw9aARwxQRA3Vt/MHil4PZs1Zzt686Oblg9ho i01dwiJk8uFZm/jxN1PfqEqfJwsVVEh+UToHkpl8B61K1GBuFmSEQf5i/J813VnUtHge rGxyIW1pTUIAMf1kBp6E3xWjgDIhn1AJnYbHY0UzEu6tKjtckrjdkmYuz9tB28R8ACf7 iBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=wMlem2F49iaxLoktVPFWVAdLPYk0I/639Nq/XiTfN40=; b=dvZRqLXjpP7dZAid9ksIe5peMH+zhiCJoCiwbZNZNN32owbSrdGxrhMhBI9x/Ha8Qw KOkyP7cIhdS/vUcmNT4B8Cu52jzjDSyFtl9Gts6KZarDRXc2fDdznBqGdFzVygk2DdDz wNegvMDKj2oq0G7zO2b7TuOFxBTIah5L9KIUADy3I9oebQr3LG1CoMuABREI0W7GPpyq Hm0FTTnG5L6fm5jTBQgqwmlxuyhv2fdpGXmBZ0AgK9pzxGCKRXZZuPxnKlMbOsglwg63 sJzsI1SYn7mVmDEmKg9M6g8pRmWmV5XARVo6Su0eLZKcC++dJ3QAYhVLDCoD/oXjS+ye rrmQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 63si5553871pla.65.2019.01.18.13.31.50; Fri, 18 Jan 2019 13:32:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729759AbfARVa2 (ORCPT + 99 others); Fri, 18 Jan 2019 16:30:28 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42776 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729598AbfARVa1 (ORCPT ); Fri, 18 Jan 2019 16:30:27 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0EF524E92A; Fri, 18 Jan 2019 21:30:27 +0000 (UTC) Received: from llong.remote.csb (dhcp-17-223.bos.redhat.com [10.18.17.223]) by smtp.corp.redhat.com (Postfix) with ESMTP id F0E361019627; Fri, 18 Jan 2019 21:30:25 +0000 (UTC) Subject: Re: Question about qspinlock nest To: Peter Zijlstra Cc: James Morse , Zhenzhong Duan , LKML , SRINIVAS , Borislav Petkov , Steven Rostedt References: <910e9fb6-d0df-4711-fe2b-244b3c20eb82@redhat.com> <20190110201217.GH2861@worktop.programming.kicks-ass.net> <20190114131613.GB10486@hirez.programming.kicks-ass.net> <830db851-d5cb-4081-8d72-e3f3a0a282df@arm.com> <20190118100229.GB27931@hirez.programming.kicks-ass.net> <20190118200657.GE27931@hirez.programming.kicks-ass.net> From: Waiman Long Openpgp: preference=signencrypt Autocrypt: addr=longman@redhat.com; prefer-encrypt=mutual; keydata= xsFNBFgsZGsBEAC3l/RVYISY3M0SznCZOv8aWc/bsAgif1H8h0WPDrHnwt1jfFTB26EzhRea XQKAJiZbjnTotxXq1JVaWxJcNJL7crruYeFdv7WUJqJzFgHnNM/upZuGsDIJHyqBHWK5X9ZO jRyfqV/i3Ll7VIZobcRLbTfEJgyLTAHn2Ipcpt8mRg2cck2sC9+RMi45Epweu7pKjfrF8JUY r71uif2ThpN8vGpn+FKbERFt4hW2dV/3awVckxxHXNrQYIB3I/G6mUdEZ9yrVrAfLw5M3fVU CRnC6fbroC6/ztD40lyTQWbCqGERVEwHFYYoxrcGa8AzMXN9CN7bleHmKZrGxDFWbg4877zX 0YaLRypme4K0ULbnNVRQcSZ9UalTvAzjpyWnlnXCLnFjzhV7qsjozloLTkZjyHimSc3yllH7 VvP/lGHnqUk7xDymgRHNNn0wWPuOpR97J/r7V1mSMZlni/FVTQTRu87aQRYu3nKhcNJ47TGY evz/U0ltaZEU41t7WGBnC7RlxYtdXziEn5fC8b1JfqiP0OJVQfdIMVIbEw1turVouTovUA39 Qqa6Pd1oYTw+Bdm1tkx7di73qB3x4pJoC8ZRfEmPqSpmu42sijWSBUgYJwsziTW2SBi4hRjU h/Tm0NuU1/R1bgv/EzoXjgOM4ZlSu6Pv7ICpELdWSrvkXJIuIwARAQABzR9Mb25nbWFuIExv bmcgPGxsb25nQHJlZGhhdC5jb20+wsF/BBMBAgApBQJYLGRrAhsjBQkJZgGABwsJCAcDAgEG FQgCCQoLBBYCAwECHgECF4AACgkQbjBXZE7vHeYwBA//ZYxi4I/4KVrqc6oodVfwPnOVxvyY oKZGPXZXAa3swtPGmRFc8kGyIMZpVTqGJYGD9ZDezxpWIkVQDnKM9zw/qGarUVKzElGHcuFN ddtwX64yxDhA+3Og8MTy8+8ZucM4oNsbM9Dx171bFnHjWSka8o6qhK5siBAf9WXcPNogUk4S fMNYKxexcUayv750GK5E8RouG0DrjtIMYVJwu+p3X1bRHHDoieVfE1i380YydPd7mXa7FrRl 7unTlrxUyJSiBc83HgKCdFC8+ggmRVisbs+1clMsK++ehz08dmGlbQD8Fv2VK5KR2+QXYLU0 rRQjXk/gJ8wcMasuUcywnj8dqqO3kIS1EfshrfR/xCNSREcv2fwHvfJjprpoE9tiL1qP7Jrq 4tUYazErOEQJcE8Qm3fioh40w8YrGGYEGNA4do/jaHXm1iB9rShXE2jnmy3ttdAh3M8W2OMK 4B/Rlr+Awr2NlVdvEF7iL70kO+aZeOu20Lq6mx4Kvq/WyjZg8g+vYGCExZ7sd8xpncBSl7b3 99AIyT55HaJjrs5F3Rl8dAklaDyzXviwcxs+gSYvRCr6AMzevmfWbAILN9i1ZkfbnqVdpaag QmWlmPuKzqKhJP+OMYSgYnpd/vu5FBbc+eXpuhydKqtUVOWjtp5hAERNnSpD87i1TilshFQm TFxHDzbOwU0EWCxkawEQALAcdzzKsZbcdSi1kgjfce9AMjyxkkZxcGc6Rhwvt78d66qIFK9D Y9wfcZBpuFY/AcKEqjTo4FZ5LCa7/dXNwOXOdB1Jfp54OFUqiYUJFymFKInHQYlmoES9EJEU yy+2ipzy5yGbLh3ZqAXyZCTmUKBU7oz/waN7ynEP0S0DqdWgJnpEiFjFN4/ovf9uveUnjzB6 lzd0BDckLU4dL7aqe2ROIHyG3zaBMuPo66pN3njEr7IcyAL6aK/IyRrwLXoxLMQW7YQmFPSw drATP3WO0x8UGaXlGMVcaeUBMJlqTyN4Swr2BbqBcEGAMPjFCm6MjAPv68h5hEoB9zvIg+fq M1/Gs4D8H8kUjOEOYtmVQ5RZQschPJle95BzNwE3Y48ZH5zewgU7ByVJKSgJ9HDhwX8Ryuia 79r86qZeFjXOUXZjjWdFDKl5vaiRbNWCpuSG1R1Tm8o/rd2NZ6l8LgcK9UcpWorrPknbE/pm MUeZ2d3ss5G5Vbb0bYVFRtYQiCCfHAQHO6uNtA9IztkuMpMRQDUiDoApHwYUY5Dqasu4ZDJk bZ8lC6qc2NXauOWMDw43z9He7k6LnYm/evcD+0+YebxNsorEiWDgIW8Q/E+h6RMS9kW3Rv1N qd2nFfiC8+p9I/KLcbV33tMhF1+dOgyiL4bcYeR351pnyXBPA66ldNWvABEBAAHCwWUEGAEC AA8FAlgsZGsCGwwFCQlmAYAACgkQbjBXZE7vHeYxSQ/+PnnPrOkKHDHQew8Pq9w2RAOO8gMg 9Ty4L54CsTf21Mqc6GXj6LN3WbQta7CVA0bKeq0+WnmsZ9jkTNh8lJp0/RnZkSUsDT9Tza9r GB0svZnBJMFJgSMfmwa3cBttCh+vqDV3ZIVSG54nPmGfUQMFPlDHccjWIvTvyY3a9SLeamaR jOGye8MQAlAD40fTWK2no6L1b8abGtziTkNh68zfu3wjQkXk4kA4zHroE61PpS3oMD4AyI9L 7A4Zv0Cvs2MhYQ4Qbbmafr+NOhzuunm5CoaRi+762+c508TqgRqH8W1htZCzab0pXHRfywtv 0P+BMT7vN2uMBdhr8c0b/hoGqBTenOmFt71tAyyGcPgI3f7DUxy+cv3GzenWjrvf3uFpxYx4 yFQkUcu06wa61nCdxXU/BWFItryAGGdh2fFXnIYP8NZfdA+zmpymJXDQeMsAEHS0BLTVQ3+M 7W5Ak8p9V+bFMtteBgoM23bskH6mgOAw6Cj/USW4cAJ8b++9zE0/4Bv4iaY5bcsL+h7TqQBH Lk1eByJeVooUa/mqa2UdVJalc8B9NrAnLiyRsg72Nurwzvknv7anSgIkL+doXDaG21DgCYTD wGA5uquIgb8p3/ENgYpDPrsZ72CxVC2NEJjJwwnRBStjJOGQX4lV1uhN1XsZjBbRHdKF2W9g weim8xU= Organization: Red Hat Message-ID: <04ff7bf3-b45a-787d-f89e-832389000c6f@redhat.com> Date: Fri, 18 Jan 2019 16:30:25 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190118200657.GE27931@hirez.programming.kicks-ass.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Fri, 18 Jan 2019 21:30:27 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2019 03:06 PM, Peter Zijlstra wrote: > On Fri, Jan 18, 2019 at 09:50:12AM -0500, Waiman Long wrote: >> On 01/18/2019 05:02 AM, Peter Zijlstra wrote: >>>> e.g. We can't take an SError during the SError handler. >>>> >>>> But we can take this SError/NMI on another CPU while the first one is still >>>> running the handler. >>>> >>>> These multiple NMIlike notifications mean having multiple locks/fixmap-slots, >>>> one per notification. This is where the qspinlock node limit comes in, as we >>>> could have more than 4 contexts. >>> Right; so Waiman was going to do a patch that reverts to test-and-set or >>> something along those lines once we hit the queue limit, which seems >>> like a good way out. Actually hitting that nesting level should be >>> exceedingly rare. >> Yes, I am working on a patch to support arbitrary levels of nesting. It >> is easy for PV qspinlock as lock stealing is supported. >> >> For native qspinlock, we cannot do lock stealing without incurring a >> certain amount of overhead in the regular slowpath code. It was up to >> 10% in my own testing. So I am exploring an alternative that can do the >> job without incurring any noticeable performance degradation in the >> slowpath. I ran into a race condition which I am still trying to find >> out where that comes from. Hopefully, I will have something to post next >> week. > Where does the overhead come from? Surely that's not just checking that > bound? It is not about checking bound, it is about how to acquire the lock without using an MCS node. The overhead comes from using atomic instruction to acquire the lock instead of non-atomic one in order to allow lock stealing. Cheers, Longman