Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 19 Jan 2019 01:43:58 +0000 (UTC)
From:   Paul Walmsley <paul@pwsan.com>
To:     Johan Hovold <johan@kernel.org>
cc:     Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Andreas Schwab <schwab@suse.de>, linux-kernel@vger.kernel.org,
        Atish Patra <atish.patra@wdc.com>,
        Anup Patel <anup@brainfault.org>,
        linux-riscv@lists.infradead.org
Subject: Re: [PATCH 4/5] riscv: treat cpu devicetree nodes without status as
 enabled
In-Reply-To: <20190118140308.9599-5-johan@kernel.org>
Message-ID: <alpine.DEB.2.21.999.1901190140510.8813@utopia.booyaka.com>
References: <20190118140308.9599-1-johan@kernel.org> <20190118140308.9599-5-johan@kernel.org>
User-Agent: Alpine 2.21.999 (DEB 260 2018-02-26)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 18 Jan 2019, Johan Hovold wrote:

> Follow the Linux convention and treat devicetree nodes without a status
> property as enabled rather than disabled, while also allowing "ok" as a
> shorthand for "okay".
> 
> Signed-off-by: Johan Hovold <johan@kernel.org>

Reviewed-by: Paul Walmsley <paul.walmsley@sifive.com>

... although I probably would have phrased the commit message slightly 
differently - something like "Use of_device_is_available() in 
riscv_of_processor_hartid(), in place of an open-coded test."  That frames 
the change as one that removes custom code in place of an existing 
standard function for the same purpose.


- Paul