Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sat, 19 Jan 2019 00:16:21 -0700
From:   Jerry Snitselaar <jsnitsel@redhat.com>
To:     iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
        Joerg Roedel <joro@8bytes.org>
Subject: Question about out_unmap section of map_sg in amd_iommu.c
Message-ID: <20190119071621.xh5s3rkqiabgjwo4@cantor>
Reply-To: Jerry Snitselaar <jsnitsel@redhat.com>
Mail-Followup-To: iommu@lists.linux-foundation.org,
        linux-kernel@vger.kernel.org, Joerg Roedel <joro@8bytes.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


  out_unmap:
          pr_err("%s: IOMMU mapping error in map_sg (io-pages: %d)\n",
                 dev_name(dev), npages);

          for_each_sg(sglist, s, nelems, i) {
                  int j, pages = iommu_num_pages(sg_phys(s), s->length, PAGE_SIZE);

                  for (j = 0; j < pages; ++j) {
                          unsigned long bus_addr;

                          bus_addr  = address + s->dma_address + (j << PAGE_SHIFT);
                          iommu_unmap_page(domain, bus_addr, PAGE_SIZE);

                          if (--mapped_pages)
                                  goto out_free_iova;

Is this condition correct?  My thought is this was meant to break out of the loop early if
all the mapped pages have been unmapped. So if (--mapped == 0) instead?

                  }
          }