Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp4376591imu; Sat, 19 Jan 2019 08:08:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN7W6RBiaXMnIncGg1H6V/+CXPO50mKqn2lb35coyM5/Gq5/UHnrpDzbcL3trzN7RghPTqWO X-Received: by 2002:a17:902:2bc5:: with SMTP id l63mr23708901plb.107.1547914094859; Sat, 19 Jan 2019 08:08:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547914094; cv=none; d=google.com; s=arc-20160816; b=DmeY93+Xf3EGXmucTLq7eEl5kIOPo10BKtK/ss9LtsRkSLXSL5PU2fQRso5H6nMXrq g2MOzjqVc5Jq92+he02uy1lMvyyV6OglRFH2umPQVt4IriCm/mxFsauxP4mG8pt7vyUO y1ssUMwSxX0XgfKnV+ijejtoyT+/Oa63UiMekUpraZP6wb3rWuvvvxEh72bU8M1BD5MZ sIjlCoKhfOqIYCMJT1Az/3Vi2nTcHlpWvuoUtc/F12s6/F9/3/MkKeJsiJ7gKl1wiUl7 yEKWL+kekH4BXqatf8EDlcsSLo7aeKA80mbUqA3UUciU40D2bpu/AUHBAOuOuxdU+E6s LJLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=igiS7JY9Tkj0t+DmCwo3tZOgXVjRsJpaBhsfH2U83Tk=; b=UFFG0SaQj64kI7wnGVdyTloUcV04r3yq0B7G+YMvhwbAydyQb/ZxT7x/QgwnkahgWo /v8NBtriP7fs5iii6uHKVnNP/U1a+JVIV41jOTTvaMNR+C7sGAVTAqiS1ERqQZPHFPP/ avYpQiwSldwnfz4rZHCTFfbuQ5A4OETvZ2hpHQag9pNlRmHIU+yQnv8U1UjdTmWdU0WP OfN0NLkt3vIHEtviFdJnrmD8IzYFinMU6OQNZfxM/b4pHBuoeP5vbOMqzMemY3ki29QT RUGo5i4LEV7lql60O6mC/r1Jx41s3BX/haQxXB3JbGknUBCh18oQzCvXMABnOxN5PC+k Wq4w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Spm1FEZb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si7182785pga.296.2019.01.19.08.07.38; Sat, 19 Jan 2019 08:08:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Spm1FEZb; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728643AbfASQFJ (ORCPT + 99 others); Sat, 19 Jan 2019 11:05:09 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36982 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728590AbfASQFG (ORCPT ); Sat, 19 Jan 2019 11:05:06 -0500 Received: by mail-pf1-f194.google.com with SMTP id y126so8098545pfb.4; Sat, 19 Jan 2019 08:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=igiS7JY9Tkj0t+DmCwo3tZOgXVjRsJpaBhsfH2U83Tk=; b=Spm1FEZb+BK5b0ThVBclsti0DUS08YWPw4T5H4EbwM6l0I3ScjPqv4jE/JZ+7I1It2 EdlpVdKqoRFsTWVjQQ8c1PXS6yXo3Lr9dcuMRODmWaRs5ZIc2etzR+G0TFSkQ0Mf0rE0 9L+SjcFvyjxrvE1P5+e7H55VgSRbHDkSBzimKHPCANYkFdC8khrqVRzT7W5mrDr0DO/B Tqy85FcB5a39A478ur0RjWSM17+NrSgyvgnOwEp2fMg0NSnoEXoropi42gpxhWUWnGhy tWJ01tt3sekFXdvxGSt2D68Jl5SYjaHZVliJ6TrfW3JeqRBo+8F6RajHkTzhJpK8VL14 G+rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=igiS7JY9Tkj0t+DmCwo3tZOgXVjRsJpaBhsfH2U83Tk=; b=SWQ7C2PdNsNur5y7cGJGWr47Obs0gLKbhc9TkCI6IUmYSW9yUJS59NzkCxajs65KVg L9lLhpEY4Ps3VgFDfxDatxMM8nu9f02wzVW2Bm3Ywr3kf3OtnshWX6OJKKsiMY32YC8W TkUzCw5mRSOV8icsPOrQWlgxkwDZoGjHCtVESSBYcy+UUe0drj8jLE+djGSQbPl3imeS wDTIbgWvN61xzWblgQ/df9gp3PTeHlAn2tqFKmQd17kpagToQtf533Rz8OqMcMCd9ilB zEGy08xF1PXI8EBpDJMXRV8vYluPIflcLvKsQBjJSw8yJKozl8PgKxiNroVohr1r8DeF fw1Q== X-Gm-Message-State: AJcUukcArwHuby9I6JL0gLlz26xMNMmDkSWJyEoddKszTolAYghXbQym 9Xzipmw4A7aQEGsQPf7/SLU= X-Received: by 2002:a63:2c82:: with SMTP id s124mr21491137pgs.73.1547913905322; Sat, 19 Jan 2019 08:05:05 -0800 (PST) Received: from localhost (68.168.130.77.16clouds.com. [68.168.130.77]) by smtp.gmail.com with ESMTPSA id t5sm15786032pfb.60.2019.01.19.08.05.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 19 Jan 2019 08:05:04 -0800 (PST) From: Yangtao Li To: myungjoo.ham@samsung.com, kyungmin.park@samsung.com, cw00.choi@samsung.com, linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Yangtao Li Subject: [PATCH 3/3] PM / devfreq: fix mem leak in devfreq_add_device() Date: Sat, 19 Jan 2019 11:04:54 -0500 Message-Id: <20190119160454.23151-3-tiny.windzz@gmail.com> X-Mailer: git-send-email 2.17.0 In-Reply-To: <20190119160454.23151-1-tiny.windzz@gmail.com> References: <20190119160454.23151-1-tiny.windzz@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'devfreq' is malloced in devfreq_add_device() and should be freed in the error handling cases, otherwise it will cause memory leak. Signed-off-by: Yangtao Li --- drivers/devfreq/devfreq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 923889229a0b..fe6c157cb7e0 100644 --- a/drivers/devfreq/devfreq.c +++ b/drivers/devfreq/devfreq.c @@ -651,7 +651,7 @@ struct devfreq *devfreq_add_device(struct device *dev, mutex_unlock(&devfreq->lock); err = set_freq_table(devfreq); if (err < 0) - goto err_out; + goto err_dev; mutex_lock(&devfreq->lock); } -- 2.17.0