Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 20 Jan 2019 11:16:39 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Anders Roxell <anders.roxell@linaro.org>
Cc:     Fabio Estevam <festevam@gmail.com>,
        Dan Williams <dan.j.williams@intel.com>,
        dmaengine@vger.kernel.org,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] dma: ixm-dma: fix warning comparison of distinct pointer
 types
Message-ID: <20190120054639.GO4635@vkoul-mobl>
References: <20190110111535.11235-1-anders.roxell@linaro.org>
 <CAOMZO5DGxXBCFbLgqeophv_Jw2nO5wiPXJXuth6CPEfSr9f9=w@mail.gmail.com>
 <CADYN=9KOqZXiFYvxWED-f_sJS6G-CqY2pPUYohGuP9Pa6VGUZQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CADYN=9KOqZXiFYvxWED-f_sJS6G-CqY2pPUYohGuP9Pa6VGUZQ@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 15-01-19, 15:14, Anders Roxell wrote:
> On Mon, 14 Jan 2019 at 22:24, Fabio Estevam <festevam@gmail.com> wrote:
> >
> > Hi Anders,
> >
> > On Thu, Jan 10, 2019 at 9:15 AM Anders Roxell <anders.roxell@linaro.org> wrote:
> > >
> > > The warning got introduced by commit 930507c18304 ("arm64: add basic
> > > Kconfig symbols for i.MX8"). Since it got enabled for arm64. The warning
> > > haven't been seen before since size_t was 'unsigned int' when built on
> > > arm32.
> > >
> > > ../drivers/dma/imx-dma.c: In function ‘imxdma_sg_next’:
> > > ../include/linux/kernel.h:846:29: warning: comparison of distinct pointer types lacks a cast
> > >    (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
> > >                              ^~
> > > ../include/linux/kernel.h:860:4: note: in expansion of macro ‘__typecheck’
> > >    (__typecheck(x, y) && __no_side_effects(x, y))
> > >     ^~~~~~~~~~~
> > > ../include/linux/kernel.h:870:24: note: in expansion of macro ‘__safe_cmp’
> > >   __builtin_choose_expr(__safe_cmp(x, y), \
> > >                         ^~~~~~~~~~
> > > ../include/linux/kernel.h:879:19: note: in expansion of macro ‘__careful_cmp’
> > >  #define min(x, y) __careful_cmp(x, y, <)
> > >                    ^~~~~~~~~~~~~
> > > ../drivers/dma/imx-dma.c:288:8: note: in expansion of macro ‘min’
> > >   now = min(d->len, sg_dma_len(sg));
> > >         ^~~
> > >
> > > Rework so that we use min_t and pass in the size_t that returns the
> > > minimum of two values, using the specified type.
> > >
> > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
> >
> > There is a typo in the Subject: s/ixm/imx/ and the prefix should be
> > dmaengine instead:
> >
> > dmaengine: imx-dma: fix warning comparison of distinct pointer types
> >
> > With that fixed:
> >
> > Reviewed-by: Fabio Estevam <festevam@gmail.com>
> 
> OK, thanks Fabio.
> 
> Dan, do you want me to resend the patch with an updated shortlog or will
> you do that when you apply the patch?

applied after fixing subsystem name and driver name

-- 
~Vinod