Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 20 Jan 2019 10:00:02 +0100
From:   Pali =?utf-8?B?Um9ow6Fy?= <pali.rohar@gmail.com>
To:     Mattias Jacobsson <2pi@mok.nu>
Cc:     yamada.masahiro@socionext.com, michal.lkml@markovi.net,
        dvhart@infradead.org, andy@infradead.org,
        platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] platform/x86: wmi: add WMI support to
 MODULE_DEVICE_TABLE()
Message-ID: <20190120090002.imufwdnvtufjgoxh@pali>
References: <cover.1547827336.git.2pi@mok.nu>
 <ff56fb53485ec75b5e8a81f306983aa7976574c5.1547827336.git.2pi@mok.nu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
        protocol="application/pgp-signature"; boundary="ep2rclsk66ehzbgb"
Content-Disposition: inline
In-Reply-To: <ff56fb53485ec75b5e8a81f306983aa7976574c5.1547827336.git.2pi@mok.nu>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--ep2rclsk66ehzbgb
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Saturday 19 January 2019 12:55:54 Mattias Jacobsson wrote:
> Add WMI support to MODULE_DEVICE_TABLE() by adding info about struct
> wmi_device_id in devicetable-offsets.c and add a WMI entry point in
> file2alias.c.
>=20
> The type argument for MODULE_DEVICE_TABLE(type, name) is wmi.
>=20
> Signed-off-by: Mattias Jacobsson <2pi@mok.nu>
> ---
>=20
> The idea of adding wmi support to MODULE_DEVICE_TABLE() originates from
> a suggestion at [1].

Thanks for implementation!

> However [2] states: "Please note that this tag
> should not be added without the reporter's permission, especially if
> the idea was not posted in a public forum." about the "Suggested-by:"
> tag.
> Pali Roh=C3=A1r: May I add a "Suggested-by:" tag?

Yes, you can!

> [1]: https://lore.kernel.org/patchwork/patch/795892/#989423
> [2]: Documentation/process/submitting-patches.rst
>=20
> ---
>  scripts/mod/devicetable-offsets.c |  3 +++
>  scripts/mod/file2alias.c          | 18 ++++++++++++++++++
>  2 files changed, 21 insertions(+)
>=20
> diff --git a/scripts/mod/devicetable-offsets.c b/scripts/mod/devicetable-=
offsets.c
> index 293004499b4d..99276a422e77 100644
> --- a/scripts/mod/devicetable-offsets.c
> +++ b/scripts/mod/devicetable-offsets.c
> @@ -225,5 +225,8 @@ int main(void)
>  	DEVID_FIELD(typec_device_id, svid);
>  	DEVID_FIELD(typec_device_id, mode);
> =20
> +	DEVID(wmi_device_id);
> +	DEVID_FIELD(wmi_device_id, guid_string);
> +
>  	return 0;
>  }
> diff --git a/scripts/mod/file2alias.c b/scripts/mod/file2alias.c
> index a37af7d71973..f014a2466ff7 100644
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -1287,6 +1287,23 @@ static int do_typec_entry(const char *filename, vo=
id *symval, char *alias)
>  	return 1;
>  }
> =20
> +/* Looks like: wmi:guid */
> +static int do_wmi_entry(const char *filename, void *symval, char *alias)
> +{
> +	DEF_FIELD_ADDR(symval, wmi_device_id, guid_string);
> +	if (strlen(*guid_string) !=3D WMI_GUID_STRING_LEN) {
> +		warn("Invalid WMI device id 'wmi:%s' in '%s'\n",
> +				*guid_string, filename);
> +		return 0;
> +	}
> +	if (snprintf(alias, 500, WMI_MODULE_PREFIX "%s", *guid_string) < 0) {
> +		warn("Could not generate all MODULE_ALIAS's in '%s'\n",
> +				filename);
> +		return 0;
> +	}
> +	return 1;
> +}
> +
>  /* Does namelen bytes of name exactly match the symbol? */
>  static bool sym_is(const char *name, unsigned namelen, const char *symbo=
l)
>  {
> @@ -1357,6 +1374,7 @@ static const struct devtable devtable[] =3D {
>  	{"fslmc", SIZE_fsl_mc_device_id, do_fsl_mc_entry},
>  	{"tbsvc", SIZE_tb_service_id, do_tbsvc_entry},
>  	{"typec", SIZE_typec_device_id, do_typec_entry},
> +	{"wmi", SIZE_wmi_device_id, do_wmi_entry},
>  };
> =20
>  /* Create MODULE_ALIAS() statements.

--=20
Pali Roh=C3=A1r
pali.rohar@gmail.com

--ep2rclsk66ehzbgb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iF0EABECAB0WIQS4VrIQdKium2krgIWL8Mk9A+RDUgUCXEQ4jwAKCRCL8Mk9A+RD
Ut4UAJ9AQad7lLnB6TGKD3SvcQMDxn2mXACeI0niLpxaZfAEh0s1M5F6yIbBMDo=
=qKIk
-----END PGP SIGNATURE-----

--ep2rclsk66ehzbgb--