Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5363837imu; Sun, 20 Jan 2019 09:13:01 -0800 (PST) X-Google-Smtp-Source: ALg8bN5cnlnCoWl4s9eoE2iTxySS2bQlwrCUecHwnZ4XnPvj+IbiJfLVS4onldXr+W2qQVXJ5pWz X-Received: by 2002:a62:7c47:: with SMTP id x68mr27065444pfc.209.1548004380999; Sun, 20 Jan 2019 09:13:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548004380; cv=none; d=google.com; s=arc-20160816; b=Lt7htzxkJs+kZy+k+x8Lg/si77Ezz2/AIXRdWOXTPYXvImAwYk5n+2+4fei22s8/dp wYUguMsIKGZ7Zk1pgcFD6mdeAEe4ovoFGRhkcS/MxPuVU5RduXZ47UczoYtSxL49SVqS ZbvQL4P/TcMuLXEdkaXK1aPh9dM9bexniW+fFiUZmC5okJLbwV5Nz5tEsRWPZWWkSxFq 5CbGqDXinkCd78X6pVdiTqp9zQWgfsl2kcYZ/6aVW0H1k4pT3q0ROm9Al0k4gMBme2H9 SHpbtrKdQSaORAo5pNuwlYcrQLcRAqf/K8hPUWEwxq2pxL3JAYflyviln3XpG4Tv+w3d yhwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:user-agent:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=m6ysdAfjtLxPWIIjrrr7TzVpr5I9wph1tDJiflr6ktg=; b=Rv4zQ11tV85Fv14ON5oLN53CDwHI+QlK0dup6UYUd42WItktU1geA7HZAfPxD/pjEE aoaWpbN5M2qszSwx4VuActZSpmZ7XlSsypAbowQB1CGcIYOu6OFv0eGkmfl5jWSO0LKC iVf5DEAHQPDdqASjevh/xAteIfgQllB8u9XamBR/V/XLA8Ku20jxxUroWzp9DAT6pE8z TTjSBk29KZanAXEDKkGIDoeFX2gwhc2t4sUqIIBmDxk8u7kmUsc3P1nRkalGpUTigYhs Z5QW1xxv5Dhmz1vhfZfI0pSn7laaP58+AcQHOiPSyWcAsrhEnwE9isMnSaMhQWFWVPsE 0PVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z5si10552065pgj.177.2019.01.20.09.12.45; Sun, 20 Jan 2019 09:13:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726763AbfATRJr (ORCPT + 99 others); Sun, 20 Jan 2019 12:09:47 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:51412 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726071AbfATRJq (ORCPT ); Sun, 20 Jan 2019 12:09:46 -0500 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0KH9iwN016288 for ; Sun, 20 Jan 2019 12:09:45 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2q4hn191c1-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sun, 20 Jan 2019 12:09:45 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 20 Jan 2019 17:09:27 -0000 Received: from b06cxnps4075.portsmouth.uk.ibm.com (9.149.109.197) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Sun, 20 Jan 2019 17:09:24 -0000 Received: from b06wcsmtp001.portsmouth.uk.ibm.com (b06wcsmtp001.portsmouth.uk.ibm.com [9.149.105.160]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0KH9NQ36619554 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 20 Jan 2019 17:09:23 GMT Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2F4E9A405C; Sun, 20 Jan 2019 17:09:23 +0000 (GMT) Received: from b06wcsmtp001.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4813DA4054; Sun, 20 Jan 2019 17:09:22 +0000 (GMT) Received: from rapoport-lnx (unknown [9.148.207.9]) by b06wcsmtp001.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Sun, 20 Jan 2019 17:09:22 +0000 (GMT) Date: Sun, 20 Jan 2019 19:09:20 +0200 From: Mike Rapoport To: Yang Fan Cc: akpm@linux-foundation.org, will.deacon@arm.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] mm/mmap.c: Remove some redundancy in arch_get_unmapped_area_topdown() References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-TM-AS-GCONF: 00 x-cbid: 19012017-0028-0000-0000-0000033BAD50 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19012017-0029-0000-0000-000023F8E007 Message-Id: <20190120170919.GB28141@rapoport-lnx> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-20_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901200139 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Sun, Jan 20, 2019 at 09:12:26AM +0100, Yang Fan wrote: > This patchset remove some redundancy in function > arch_get_unmapped_area_topdown(). > > [PATCH 1/2] mm/mmap.c: Remove redundant variable 'addr' in > arch_get_unmapped_area_topdown() > [PATCH 2/2] mm/mmap.c: Remove redundant const qualifier of the no-pointer > parameters > > Yang Fan (2): > mm/mmap.c: Remove redundant variable 'addr' in > arch_get_unmapped_area_topdown() > mm/mmap.c: Remove redundant const qualifier of the no-pointer > parameters I think it would be better to merge these patches into one. For the merged patch feel free to add Reviewed-by: Mike Rapoport > mm/mmap.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > -- > 2.17.1 > -- Sincerely yours, Mike.