Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 20 Jan 2019 12:27:55 -0700
From:   Jonathan Corbet <corbet@lwn.net>
To:     Tony Jones <tonyj@suse.de>
Cc:     Seeteena Thoufeek <s1seetee@linux.vnet.ibm.com>,
        peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
        alexander.shishkin@linux.intel.com, jolsa@redhat.com,
        namhyung@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] perf scripts python: Add Python 3 support to
 exported-sql-viewer.py
Message-ID: <20190120122755.1a8fe456@lwn.net>
In-Reply-To: <f086e4fb-0bbf-9e21-25e2-708b092f1636@suse.de>
References: <1547718344-27382-1-git-send-email-s1seetee@linux.vnet.ibm.com>
        <1547718344-27382-3-git-send-email-s1seetee@linux.vnet.ibm.com>
        <f086e4fb-0bbf-9e21-25e2-708b092f1636@suse.de>
Organization: LWN.net
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 18 Jan 2019 16:45:04 -0800
Tony Jones <tonyj@suse.de> wrote:

> On 1/17/19 1:45 AM, Seeteena Thoufeek wrote:
> 
> > +if sys.version_info[0] < 3:
> > +    import cPickle
> > +else:
> > +    import _pickle as cPickle  
> 
> Do you really need this?
> 
> pickle is already in Python2.

Did you mean in Python3?  I would agree that using it is better than
importing the semi-hidden _pickle module.

That said, I'll echo the questions about testing.  Pickle works in
Python3, but it is fraught with all kinds of bytes/str and encoding
issues; I've found it sufficiently fragile in practice that I really just
try to avoid it.  How have you verified that this script works under both
versions of Python?

Thanks,

jon