Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261423AbUCAUql (ORCPT ); Mon, 1 Mar 2004 15:46:41 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261429AbUCAUql (ORCPT ); Mon, 1 Mar 2004 15:46:41 -0500 Received: from ns.suse.de ([195.135.220.2]:21979 "EHLO Cantor.suse.de") by vger.kernel.org with ESMTP id S261423AbUCAUqk (ORCPT ); Mon, 1 Mar 2004 15:46:40 -0500 To: Andrew Morton Cc: yi.zhu@intel.com, linux-kernel@vger.kernel.org Subject: Re: [start_kernel] Suggest to move parse_args() before trap_init() References: <20040301025637.338f41cf.akpm@osdl.org> From: Andi Kleen Date: 01 Mar 2004 21:46:38 +0100 In-Reply-To: <20040301025637.338f41cf.akpm@osdl.org.suse.lists.linux.kernel> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 20 Andrew Morton writes: > I think the only problem with this is if we get a fault during > parse_args(), the kernel flies off into outer space. So you lose some > debuggability when using an early console. > > But 2.4 does trap_init() after parse_args() and nobody has complained, as > did 2.6 until recently. So the change is probably OK. The standard way to fix this is to add an explicit check for lapic to the early argument parsing in setup.c (but keep the __setup so that no unknown argument is reported). I think that's better than moving it and getting possible bugs that cannot even be catched with early printk. Another way that i've considered on x86-64 for 2.7 at least is a special __early_setup() for this -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/