Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] squashfs: fix mtime underflow on 64 bit system
To:     <phillip@squashfs.org.uk>, <linux-kernel@vger.kernel.org>
CC:     <houtao1@huawei.com>, <zhaohongjiang@huawei.com>
References: <20190117082148.129347-1-zhengbin13@huawei.com>
From:   "zhengbin (A)" <zhengbin13@huawei.com>
Message-ID: <ba753b88-7134-b5aa-c39a-05aed9001b13@huawei.com>
Date:   Mon, 21 Jan 2019 10:18:01 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.3.0
MIME-Version: 1.0
In-Reply-To: <20190117082148.129347-1-zhengbin13@huawei.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

hi Phillip, when you have time, help to confirm it?

Looking forward to your reply.

On 2019/1/17 16:21, zhengbin wrote:
> If we change the file mtime to 1969, mksquashfs and mount,
> the atime/mtime of this file will be underflow. The reason is
> treating timestamps with the high bit set as positive
> times(before 1970), which should be set as negative times
> just like on 32 bit system. After this, the poissble range
> of timestamps will be 1901-2038(prev is 1970-2106) on 64
> bit system.
> 
> Signed-off-by: zhengbin <zhengbin13@huawei.com>
> ---
>  fs/squashfs/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/squashfs/inode.c b/fs/squashfs/inode.c
> index e9793b1e49a5..03a6ef77a2d2 100644
> --- a/fs/squashfs/inode.c
> +++ b/fs/squashfs/inode.c
> @@ -72,7 +72,7 @@ static int squashfs_new_inode(struct super_block *sb, struct inode *inode,
>  	i_uid_write(inode, i_uid);
>  	i_gid_write(inode, i_gid);
>  	inode->i_ino = le32_to_cpu(sqsh_ino->inode_number);
> -	inode->i_mtime.tv_sec = le32_to_cpu(sqsh_ino->mtime);
> +	inode->i_mtime.tv_sec = (signed int)le32_to_cpu(sqsh_ino->mtime);
>  	inode->i_atime.tv_sec = inode->i_mtime.tv_sec;
>  	inode->i_ctime.tv_sec = inode->i_mtime.tv_sec;
>  	inode->i_mode = le16_to_cpu(sqsh_ino->mode);
> --
> 2.16.2.dirty
> 
> 
> .
>