Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6129420imu; Mon, 21 Jan 2019 03:47:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN6+bU3EKzNaro4Ur2sroOKE0TAT5ybzQF8QNPkgAdbg9IC2JZyOlMA4zN9QPGDUBXhwkgIf X-Received: by 2002:a63:6486:: with SMTP id y128mr27902015pgb.18.1548071262350; Mon, 21 Jan 2019 03:47:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548071262; cv=none; d=google.com; s=arc-20160816; b=MCWJgiKgucsaWIztWgqRdI5X95Bx72MiM+ngQSE7ac9digKC1of+375IawUFElqwiM 463VIy3qaLUa8OoNRoTMqLCve13alFQy4XYG5gJZHpQczAXS1bQz9GJc0u1LhC2C5cJ3 gRq0aFH6/TkdYQL5UhkiQnKiPS8scS8xxVHv8hR9Ov61VbEz8jPd785i6YM5xVBjO6dm yxM31axDT2xOL6Vbyb/zkxtgrt/69gylyoYOxOqzja1Q4J3wx/JNW1pwPSo5riw2ckd/ c5Ju+RWt8DevkeKlJC9UsdZSa/v4lBH4AMG2Ugxzt1n+sr6VtE7Jdfet39DCEGudO0Ba 5zwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=brxv/tjPVpV8ykPLBSI3YsolLBU8qbUq7D6kX/iBZA0=; b=bVzFBxTl1Ll9UO/F6wio179OvVzQqfy+sNKhQOBPFaiMgFU36FnAMgPSFR1qdOpGEi t5VRStjkh+YaBRyw0gbRVN+3V7hAJZE+VCo58VEt40lCTeZE/sYTADthfTSTGqUGNQPr RUWvKvFbUlpb7t1KZ1Ll1TCf+cKkLNg0RP+HuqqcfZIgeOTtHdSOXzNEowjXl0B5ANas XoqFMQqRzL7tE1qYFunLs2zFdJJ4SiJSt/ZCppX3nBZgSbfIPe14K7bh+OjD4LZfTNaD S1uUQf4Sqacw01oxdlcrL/DdgvmGhdN3ZAL7pYA6vktTCfn0gFBkhY58yNP0/XPbdBfq JIUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eX0V9y6N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s4si12398109pga.377.2019.01.21.03.47.26; Mon, 21 Jan 2019 03:47:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=eX0V9y6N; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728187AbfAULpP (ORCPT + 99 others); Mon, 21 Jan 2019 06:45:15 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:44978 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727679AbfAULpP (ORCPT ); Mon, 21 Jan 2019 06:45:15 -0500 Received: by mail-ed1-f66.google.com with SMTP id y56so16286554edd.11 for ; Mon, 21 Jan 2019 03:45:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=brxv/tjPVpV8ykPLBSI3YsolLBU8qbUq7D6kX/iBZA0=; b=eX0V9y6NVRBULPJE+6gFY+Oi35pr3mfL9L8xfLA4cNwnGrm2kEZD9Llc0/MMf70GiX m/nNLXRNvWQGMucA6yYH3o02a2hpwe33TtrK0R85NO9f6j+dnUKvfIpEZSSn80cQlMdU dAOehnSttB0aTQElOHcwZtw1XMlx4RgGzFjlE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=brxv/tjPVpV8ykPLBSI3YsolLBU8qbUq7D6kX/iBZA0=; b=FOcY+sRFc9CfELyujJznynCeQ7sscRDXn083qNF6gGfgFIV/N6XlVMFx4tOxUq+bt0 HllZ7U+l5MGUJartvllVT8adSkOSk1YOZvV2m1QPmRpBQa3NN96tInERIjcpWChBeSbC zND9GXeOCP3V/ZNB+1MABDr7G2h8b6D9Y8fCOl1dU1ACYZ/Qh66DvM5NIo2lRrO4zMQD /jWUn58h57vDH9CjVv2ADz7MFE2ukTy2J+HjXcD3d1eAmxr/3UF0q/XjGUB4jiV1SJZm 2LdPtdI/9GfyOFxnzKEjkEUM+/Sptyxp7Gx0BkMLN5UqzQBSKALeExB0k53PE5C+uCVO 9Wcw== X-Gm-Message-State: AJcUukeS9o5vu2Ax//ANrPkD6IcEMlPeGyjycm2TjbwtudoAkzzSu/F4 G2Pr0rfucr17nASxvbFKrCJ8cg== X-Received: by 2002:a50:c20a:: with SMTP id n10mr27327731edf.60.1548071112463; Mon, 21 Jan 2019 03:45:12 -0800 (PST) Received: from andrea (85.100.broadband17.iol.cz. [109.80.100.85]) by smtp.gmail.com with ESMTPSA id p1-v6sm4663904ejo.49.2019.01.21.03.45.11 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Jan 2019 03:45:11 -0800 (PST) Date: Mon, 21 Jan 2019 12:45:05 +0100 From: Andrea Parri To: Dmitry Vyukov Cc: Elena Reshetova , Kees Cook , Peter Zijlstra , Alan Stern , "Paul E. McKenney" , Will Deacon , Andrew Morton , Andrey Ryabinin , Anders Roxell , Mark Rutland , LKML Subject: Re: [PATCH] kcov: convert kcov.refcount to refcount_t Message-ID: <20190121114505.GA7307@andrea> References: <1547634429-772-1-git-send-email-elena.reshetova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 21, 2019 at 10:52:37AM +0100, Dmitry Vyukov wrote: [...] > > Am I missing something or refcount_dec_and_test does not in fact > > provide ACQUIRE ordering? > > > > +case 5) - decrement-based RMW ops that return a value > > +----------------------------------------------------- > > + > > +Function changes: > > + atomic_dec_and_test() --> refcount_dec_and_test() > > + atomic_sub_and_test() --> refcount_sub_and_test() > > + no atomic counterpart --> refcount_dec_if_one() > > + atomic_add_unless(&var, -1, 1) --> refcount_dec_not_one(&var) > > + > > +Memory ordering guarantees changes: > > + fully ordered --> RELEASE ordering + control dependency > > > > I think that's against the expected refcount guarantees. When I > > privatize an atomic_dec_and_test I would expect that not only stores, > > but also loads act on a quiescent object. But loads can hoist outside > > of the control dependency. > > > > Consider the following example, is it the case that the BUG_ON can still fire? Can't it fire in an SC world? (wrong example, or a Monday morning? ;D) > > > > struct X { > > refcount_t rc; // == 2 > > int done1, done2; // == 0 > > }; > > > > // thread 1: > > x->done1 = 1; > > if (refcount_dec_and_test(&x->rc)) > > BUG_ON(!x->done2); > > > > // thread 2: > > x->done2 = 1; > > if (refcount_dec_and_test(&x->rc)) > > BUG_ON(!x->done1); > > +more people knowledgeable in memory ordering > > Unfortunately I can't find a way to reply to the > Documentation/core-api/refcount-vs-atomic.rst patch review thread. > > The refcount_dec_and_test guarantees look too weak to me, see the > example above. Shouldn't refcount_dec_and_test returning true give the > object in fully quiescent state? Why only control dependency? Loads > can hoist across control dependency, no? As you remarked, the doc. says CTRL+RELEASE (so yes, loads can hoist); AFAICR, implementations do comply to this requirement. (FWIW, I sometimes think at this "weird" ordering as a weak "acq_rel", the latter, acq_rel, being missing from the current APIs.) Andrea > > > > > > Suggested-by: Kees Cook > > > Reviewed-by: David Windsor > > > Reviewed-by: Hans Liljestrand > > > Signed-off-by: Elena Reshetova > > > --- > > > kernel/kcov.c | 9 +++++---- > > > 1 file changed, 5 insertions(+), 4 deletions(-) > > > > > > diff --git a/kernel/kcov.c b/kernel/kcov.c > > > index c2277db..051e86e 100644 > > > --- a/kernel/kcov.c > > > +++ b/kernel/kcov.c > > > @@ -20,6 +20,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > #include > > > > > > /* Number of 64-bit words written per one comparison: */ > > > @@ -44,7 +45,7 @@ struct kcov { > > > * - opened file descriptor > > > * - task with enabled coverage (we can't unwire it from another task) > > > */ > > > - atomic_t refcount; > > > + refcount_t refcount; > > > /* The lock protects mode, size, area and t. */ > > > spinlock_t lock; > > > enum kcov_mode mode; > > > @@ -228,12 +229,12 @@ EXPORT_SYMBOL(__sanitizer_cov_trace_switch); > > > > > > static void kcov_get(struct kcov *kcov) > > > { > > > - atomic_inc(&kcov->refcount); > > > + refcount_inc(&kcov->refcount); > > > } > > > > > > static void kcov_put(struct kcov *kcov) > > > { > > > - if (atomic_dec_and_test(&kcov->refcount)) { > > > + if (refcount_dec_and_test(&kcov->refcount)) { > > > vfree(kcov->area); > > > kfree(kcov); > > > } > > > @@ -312,7 +313,7 @@ static int kcov_open(struct inode *inode, struct file *filep) > > > if (!kcov) > > > return -ENOMEM; > > > kcov->mode = KCOV_MODE_DISABLED; > > > - atomic_set(&kcov->refcount, 1); > > > + refcount_set(&kcov->refcount, 1); > > > spin_lock_init(&kcov->lock); > > > filep->private_data = kcov; > > > return nonseekable_open(inode, filep); > > > -- > > > 2.7.4 > > >