Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   James Morse <james.morse@arm.com>
Subject: Re: [PATCH v2 3/4] arm64: kprobes: Move exception_text check in
 blacklist
To:     Masami Hiramatsu <mhiramat@kernel.org>
Cc:     Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Pratyush Anand <panand@redhat.com>,
        "David A . Long" <dave.long@linaro.org>,
        linux-arm-kernel@lists.infradead.org,
        linux-kernel <linux-kernel@vger.kernel.org>
References: <154753341900.31541.8135985235882849464.stgit@devbox>
 <154753350520.31541.11995657762766497151.stgit@devbox>
Message-ID: <47b290e9-0dcc-d9cd-3a7d-f6a4c4c3ca60@arm.com>
Date:   Mon, 21 Jan 2019 12:08:59 +0000
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <154753350520.31541.11995657762766497151.stgit@devbox>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,

On 15/01/2019 06:25, Masami Hiramatsu wrote:
> Move exception/irqentry text address check in blacklist,
> since those are symbol based rejection.
> 
> If we prohibit probing on the symbols in exception_text,
> those should be blacklisted.

We need to blacklist this as its where do_debug_exception() lives, which kprobes
depends on for single-stepping.

Reviewed-by: James Morse <james.morse@arm.com>


Thanks!

James