Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6274348imu; Mon, 21 Jan 2019 06:12:57 -0800 (PST) X-Google-Smtp-Source: ALg8bN4wpiEh/3Cf3zKze5PfwZapik+IwtrNJ76D40n58fvkkv1a+/4TvY603+ClcnMXmm7bhf2/ X-Received: by 2002:a65:43c5:: with SMTP id n5mr28990709pgp.250.1548079976986; Mon, 21 Jan 2019 06:12:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548079976; cv=none; d=google.com; s=arc-20160816; b=BS1ZOFKfR3OyFPuiZaMkbWTLQG9exdqd2jRA6tVr/qmjj4Q9N61aI/HwNCgUAJd3Wr vyOW2eXfxByoDxtkblsmjBcd0hKZOOIj7mxFtKivAKLVLRnAN/+FI4yHpJURUg6pRSOA ArdmseL/qcNMoDIkn85gRwllXiSzRGHWDWk67ocB3x2iwzW2wjdCoOfm4akGv2c5Rfpz g2wzQP6lvRJpPBPzTttq1XXbCWDCUQHKCCXzXsbKWURoWVa3AUsP1DZkwy1nWjKMh//6 BZ2xZY03wqP+mWVQFVumbpO8UNDbLYtMu63RbPAYx1KIo2rIuj9d6zbkOTMymNWC/4Fq skfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=BHNE8l84HqYSc8pqDzNTs+uk4zHVPjiyxPaQ8vkSuqk=; b=ose9hWIffh7POA9fpqGSVZgqYTPswutr4ijr2/KjZI91cHdtpOChS4WpwhLQPbwLhC 8314hHQJFPE1X5rKn5SkJkrkZUsMEymVSjfdh9EapIZnlmYXIQI6jsqXliZ2F+c5Rpt1 qO2/7MEso+DaQYqOZY9h4/pTiSrdUX13dYUL9NGpCo1Bokx7pLrKR88fmkfyRM3afzB3 KX55pPeJuoC0wlSAmb2cFbDiLimZLhvvVq/KLFV6rRzOhAIwY9XKV/WZdsY59c8GZnO4 TxEkf4xxgu6+JrfrdJUoYrCdJ/decpR2vaAK4Bh/fGg2zHjt/lm7bhI9FHwSQZbjWPeI M26Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xnRINeOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i4si12207362pfg.218.2019.01.21.06.12.41; Mon, 21 Jan 2019 06:12:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=xnRINeOW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731453AbfAUNyQ (ORCPT + 99 others); Mon, 21 Jan 2019 08:54:16 -0500 Received: from mail.kernel.org ([198.145.29.99]:38286 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731424AbfAUNyM (ORCPT ); Mon, 21 Jan 2019 08:54:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D43C621019; Mon, 21 Jan 2019 13:54:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548078851; bh=L1pb08f6z7zxYR16XpGyT9bxk/+ZvD8S0Gmc66ELjOI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xnRINeOW6hVLEltryZBqtiD7Kkh+nogldrZ3HbagjYaYsdmavCpPAQfATS6BAn8ri KE/sIM2mYuDKi0h7oJvQk5Zx0thtpO0HAu/6UhoYULzZwqDzwGMXq39Sx89jkhXk3j raZRLjvG+r+pvapURWYyVSLua6b4h6SGFgZpTHb8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hans Verkuil , syzbot+57c3d83d71187054d56f@syzkaller.appspotmail.com, Mauro Carvalho Chehab Subject: [PATCH 4.14 39/59] media: vivid: set min width/height to a value > 0 Date: Mon, 21 Jan 2019 14:44:04 +0100 Message-Id: <20190121122501.140288298@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190121122456.529172919@linuxfoundation.org> References: <20190121122456.529172919@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Hans Verkuil commit 9729d6d282a6d7ce88e64c9119cecdf79edf4e88 upstream. The capture DV timings capabilities allowed for a minimum width and height of 0. So passing a timings struct with 0 values is allowed and will later cause a division by zero. Ensure that the width and height must be >= 16 to avoid this. Signed-off-by: Hans Verkuil Reported-by: syzbot+57c3d83d71187054d56f@syzkaller.appspotmail.com Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/platform/vivid/vivid-vid-common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/vivid/vivid-vid-common.c +++ b/drivers/media/platform/vivid/vivid-vid-common.c @@ -33,7 +33,7 @@ const struct v4l2_dv_timings_cap vivid_d .type = V4L2_DV_BT_656_1120, /* keep this initialization for compatibility with GCC < 4.4.6 */ .reserved = { 0 }, - V4L2_INIT_BT_TIMINGS(0, MAX_WIDTH, 0, MAX_HEIGHT, 14000000, 775000000, + V4L2_INIT_BT_TIMINGS(16, MAX_WIDTH, 16, MAX_HEIGHT, 14000000, 775000000, V4L2_DV_BT_STD_CEA861 | V4L2_DV_BT_STD_DMT | V4L2_DV_BT_STD_CVT | V4L2_DV_BT_STD_GTF, V4L2_DV_BT_CAP_PROGRESSIVE | V4L2_DV_BT_CAP_INTERLACED)