Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <47c97a0e4fc1a520d166b69d4ca19e36049f8eba.camel@redhat.com>
Subject: Re: [PATCH] net/ipv6: lower the level of "link is not ready"
 messages
From:   Thomas Haller <thaller@redhat.com>
To:     Lubomir Rintel <lkundrak@v3.sk>,
        "David S. Miller" <davem@davemloft.net>,
        Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
        Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 21 Jan 2019 16:52:04 +0100
In-Reply-To: <20190121135419.615989-1-lkundrak@v3.sk>
References: <20190121135419.615989-1-lkundrak@v3.sk>
Organization: Red Hat
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-01-21 at 14:54 +0100, Lubomir Rintel wrote:
> This message gets logged far too often for how interesting is it.
> 
> Most distributions nowadays configure NetworkManager to use randomly
> generated MAC addresses for Wi-Fi network scans. The interfaces end
> up
> being periodically brought down for the address change. When they're
> subsequently brought back up, the message is logged, eventually
> flooding
> the log.
> 
> Perhaps the message is not all that helpful: it seems to be more
> interesting to hear when the addrconf actually start, not when it
> does
> not. Let's lower its level.
> 
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>


Hi,

a NetworkManager maintainer here.

Acked-By: Thomas Haller <thaller@redhat.com>


> ---
>  net/ipv6/addrconf.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
> index 93d5ad2b1a69..ba155841dc15 100644
> --- a/net/ipv6/addrconf.c
> +++ b/net/ipv6/addrconf.c
> @@ -3495,8 +3495,8 @@ static int addrconf_notify(struct
> notifier_block *this, unsigned long event,
>  
>  			if (!addrconf_link_ready(dev)) {
>  				/* device is not ready yet. */
> -				pr_info("ADDRCONF(NETDEV_UP): %s: link
> is not ready\n",
> -					dev->name);
> +				pr_debug("ADDRCONF(NETDEV_UP): %s: link
> is not ready\n",
> +					 dev->name);
>  				break;
>  			}