Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <a6b96055a16da89a3cc20c145b65beb61c55f0a1.camel@perches.com>
Subject: Re: [PATCH 1/3] PM / devfreq: fix indentation in
 devfreq_add_device()
From:   Joe Perches <joe@perches.com>
To:     Chanwoo Choi <cw00.choi@samsung.com>,
        Yangtao Li <tiny.windzz@gmail.com>, myungjoo.ham@samsung.com,
        kyungmin.park@samsung.com, linux-pm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org
Date:   Mon, 21 Jan 2019 08:39:20 -0800
In-Reply-To: <e45d38da-1dc4-c1ca-83d4-0efeb64acef1@samsung.com>
References: <CGME20190119183407epcas1p4958e4526d07c36605307c49b0c0e2e2c@epcas1p4.samsung.com>
         <20190119160454.23151-1-tiny.windzz@gmail.com>
         <e45d38da-1dc4-c1ca-83d4-0efeb64acef1@samsung.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-01-21 at 10:58 +0900, Chanwoo Choi wrote:
> On 19. 1. 20. 오전 1:04, Yangtao Li wrote:
> > To beautify the code format.

I believe half of the changes are actually _less_ beautiful.

> > diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
[]
> > @@ -683,16 +683,15 @@ struct devfreq *devfreq_add_device(struct device *dev,
> >  		goto err_out;
> >  	}
> >  
> > -	devfreq->trans_table =
> > -		devm_kzalloc(&devfreq->dev,
> > -			     array3_size(sizeof(unsigned int),
> > -					 devfreq->profile->max_state,
> > -					 devfreq->profile->max_state),
> > -			     GFP_KERNEL);
> > +	devfreq->trans_table = devm_kzalloc(&devfreq->dev,
> > +					    array3_size(sizeof(unsigned int),
> > +					    devfreq->profile->max_state,
> > +					    devfreq->profile->max_state),
> > +					    GFP_KERNEL);

I think this bit is worse because the array3_size arguments
are no longer aligned.

> >  	devfreq->time_in_state = devm_kcalloc(&devfreq->dev,
> > -						devfreq->profile->max_state,
> > -						sizeof(unsigned long),
> > -						GFP_KERNEL);
> > +					      devfreq->profile->max_state,
> > +					      sizeof(unsigned long),
> > +					      GFP_KERNEL);

and this bit is better.