Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6488135imu; Mon, 21 Jan 2019 09:43:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN7evqh6HHyVzsmhp0SDiPCUG4+0g/lmbM3wSROb0eQAAW/ytO8/Mebap8lDbrojcj0B6oIO X-Received: by 2002:a62:9fd9:: with SMTP id v86mr30343946pfk.191.1548092633313; Mon, 21 Jan 2019 09:43:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548092633; cv=none; d=google.com; s=arc-20160816; b=xrnKil7PofjlNJSFWaoFP2QOReUDMXyKwIThQEAafivtX2TJA6PrTfR1mVCotL4TcW RjObJVZWBcShwoJ1mmkMD988uSsNwt8tNtcEDP4TCK3JENQggKxFkJsEYnhsvt78QyYD WcgJGIf1lYmG7vu9yo87t6QAMps++bpV9BIRBl5xum/MQhc6GWo1e4oDcvLKzPrAqaFM bx759GtN0vXoN68S1f/b+GUR+eWysSeYhY221Ny/R0iELQYhDAmJAhUGeV7J876Mhnej F5b4KXkTDen2uGv49d40CTWeBn0ljBOTqHv8sQBH6WCGaa0IvjzbTWdBPrQ7Go3a4snq B5AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1Av6Br38xV1peDDqP8IWKWfmS6t4wk/RMHzPcwnf3KE=; b=N/K7jRhILbnXyjsOuRRN7Ckpw8Nj2it4tgVE7d1/B3u4YDwgs2p83qwDsM/Xy6qXJf JkEeOiG5Kamg/QyhlfQFZzMmr2gvq5EAyQyfIU6CdT5Gp3M8alNCtBmLBG9voFIe38fb Ke1j/8mNGXkswotAbKUv+B/sQtAoGSA5vYVdAtE1MuJTQtw0vr4dtygKfALpxIJCjBma cGerRImT5Fdx3JuJNRDiWMrJZxbcmYoW7oLQs2+pIwArlrHBbX4XQwWTj/DSoDF7Stpv 4vh+CHBQ3WgxuR1veTduccsO0FdOZuqse1rmolYPNoHpm5ojnw1NQ4tPdn591DdRA5bJ khJA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t4si12905920pfj.183.2019.01.21.09.43.37; Mon, 21 Jan 2019 09:43:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727280AbfAUR20 (ORCPT + 99 others); Mon, 21 Jan 2019 12:28:26 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44866 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725996AbfAUR20 (ORCPT ); Mon, 21 Jan 2019 12:28:26 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 10CAF4E8A8; Mon, 21 Jan 2019 17:28:26 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.34.27.18]) by smtp.corp.redhat.com (Postfix) with SMTP id 36AAD5E1BF; Mon, 21 Jan 2019 17:28:24 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Mon, 21 Jan 2019 18:28:25 +0100 (CET) Date: Mon, 21 Jan 2019 18:28:23 +0100 From: Oleg Nesterov To: Elena Reshetova Cc: mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, akpm@linux-foundation.org, keescook@chromium.org, tglx@linutronix.de Subject: Re: [PATCH 2/5] sched: convert signal_struct.sigcnt to refcount_t Message-ID: <20190121172822.GB8088@redhat.com> References: <1547814450-18902-1-git-send-email-elena.reshetova@intel.com> <1547814450-18902-3-git-send-email-elena.reshetova@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1547814450-18902-3-git-send-email-elena.reshetova@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Mon, 21 Jan 2019 17:28:26 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18, Elena Reshetova wrote: > > For the signal_struct.sigcnt it might make a difference > in following places: > - put_signal_struct(): decrement in refcount_dec_and_test() only > provides RELEASE ordering and control dependency on success > vs. fully ordered atomic counterpart this is fine. Reviewed-by: Oleg Nesterov