Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6489694imu; Mon, 21 Jan 2019 09:45:35 -0800 (PST) X-Google-Smtp-Source: ALg8bN7S3VLHQQb9fMSQHfiLi0th7av7mFbCiVfXJIuO7GrlBHDFJGsE7irNyljLKYdTvYzmh8Ns X-Received: by 2002:a62:7892:: with SMTP id t140mr30440843pfc.237.1548092735271; Mon, 21 Jan 2019 09:45:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548092735; cv=none; d=google.com; s=arc-20160816; b=qV7xft1i9CUocF06H7y687UwELcretO1QBezvwKpiPkN4W7TZcC2Qr56nC/MjGh+Uc Wd/kLEKAniet1et4L5KKSVFnb3a7kuQqeAXENS/IjNja3CaNJ0DzOWqUQo+ckyEDmGWY XGh+O0IWRhnNQbX0SMqElfkqwfl0PkN0io9F205wTvbuG6aATKq6r+jZW+KVktolnkua inteMBhAIeMlmV4+VMyfxXuoUI471qxZpbzZVtU7jnP3XFOBKUuW9+O3xpNEhPd98/Xk jqbaAnhou8md4vL5x20VuAIf9ZQ4OpXdLx9VjJ9vm9iyVmdRPRFp9FrazOW55d+AZJ56 2s/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=JPe5/6wYrdUI0oV67glXpIPOwLJKc3U+L5BvLODod4s=; b=erCifgOwi++erW6LrRzj7jKpgziJrqWpgZlJPJMjhFDxN0YJbkDUA0/lIEV1iBr0Pd Nm3zmNd/0ecrzVyt++gM5JE3uu2mCJlfCl4EB1rTZM2fFV3aaK4ZT+Q4dkbGqb7bSvXd yhkgFo8fcT4XP0l3bkANKpc3bV+RcFBYbyTAf1gx8ARgJZ4lFtNucnBCjBxw8dTAOCMp NLxTeTqqmvfKaQBUwiTpTqTJ75W3JL1TxH9PQ3DsSpdKGKwrOckkbJxbESr8S3n/OEbd minptlw2U0iBCrIiACPgcOMsyDyD5PtLIPY/q588YoudpEldbIIMq0PL63qekvB9wg8z hlHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i1si12755574pfj.276.2019.01.21.09.45.19; Mon, 21 Jan 2019 09:45:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728139AbfAURms (ORCPT + 99 others); Mon, 21 Jan 2019 12:42:48 -0500 Received: from smtp2.provo.novell.com ([137.65.250.81]:33081 "EHLO smtp2.provo.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725908AbfAURms (ORCPT ); Mon, 21 Jan 2019 12:42:48 -0500 Received: from localhost.localdomain (prv-ext-foundry1int.gns.novell.com [137.65.251.240]) by smtp2.provo.novell.com with ESMTP (TLS encrypted); Mon, 21 Jan 2019 10:42:40 -0700 From: Davidlohr Bueso To: akpm@linux-foundation.org Cc: dledford@redhat.com, jgg@mellanox.com, jack@suse.de, ira.weiny@intel.com, linux-rdma@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dave@stgolabs.net Subject: [PATCH v2 -next 0/6] mm: make pinned_vm atomic and simplify users Date: Mon, 21 Jan 2019 09:42:14 -0800 Message-Id: <20190121174220.10583-1-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Changes from v1 (https://patchwork.kernel.org/cover/10764923/): - Converted pinned_vm to atomic64 instead of atomic_long such that infiniband need not worry about overflows. - Rebased patch 1 and added Ira's reviews as well as Parvi's review for patch 5 (thanks!). -------- Hi, The following patches aim to provide cleanups to users that pin pages (mostly infiniband) by converting the counter to atomic -- note that Daniel Jordan also has patches[1] for the locked_vm counterpart and vfio. Apart from removing a source of mmap_sem writer, we benefit in that we can get rid of a lot of code that defers work when the lock cannot be acquired, as well as drivers avoiding mmap_sem altogether by also converting gup to gup_fast() and letting the mm handle it. Users that do the gup_longterm() remain of course under at least reader mmap_sem. Everything has been compile-tested _only_ so I hope I didn't do anything too stupid. Please consider for v5.1. On a similar topic and potential follow up, it would be nice to resurrect Peter's VM_PINNED idea in that the broken semantics that occurred after bc3e53f682 ("mm: distinguish between mlocked and pinned pages") are still present. Also encapsulating internal mm logic via mm[un]pin() instead of drivers having to know about internals and playing nice with compaction are all wins. Thanks! [1] https://lkml.org/lkml/2018/11/5/854 Davidlohr Bueso (6): mm: make mm->pinned_vm an atomic64 counter mic/scif: do not use mmap_sem drivers/IB,qib: do not use mmap_sem drivers/IB,hfi1: do not se mmap_sem drivers/IB,usnic: reduce scope of mmap_sem drivers/IB,core: reduce scope of mmap_sem drivers/infiniband/core/umem.c | 47 +++----------------- drivers/infiniband/hw/hfi1/user_pages.c | 12 ++--- drivers/infiniband/hw/qib/qib_user_pages.c | 69 ++++++++++------------------- drivers/infiniband/hw/usnic/usnic_ib_main.c | 2 - drivers/infiniband/hw/usnic/usnic_uiom.c | 56 +++-------------------- drivers/infiniband/hw/usnic/usnic_uiom.h | 1 - drivers/misc/mic/scif/scif_rma.c | 38 +++++----------- fs/proc/task_mmu.c | 2 +- include/linux/mm_types.h | 2 +- kernel/events/core.c | 8 ++-- kernel/fork.c | 2 +- mm/debug.c | 3 +- 12 files changed, 57 insertions(+), 185 deletions(-) -- 2.16.4