Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6619849imu; Mon, 21 Jan 2019 12:17:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN4X9A5r8o2O7nK7Zph9KHf4SKAj1mnxZw7+A5brZq1YtRySupviuzLmUbw0PLEgpOznXiHG X-Received: by 2002:a63:955a:: with SMTP id t26mr29709743pgn.449.1548101838286; Mon, 21 Jan 2019 12:17:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548101838; cv=none; d=google.com; s=arc-20160816; b=wZe1PMryS+g94o/48peZWfmSIgKsIrn4Oo4gWAER1iLjZDZPL2T6fs71xcnyt0fdXX cDIxjwtPqGF0R4Q4tsyn1vqBPVbA0tBvh6PHLPomp54vvhx6nISm0IkXg6W20NiZ9SOV 7dpztN6wciJ5QKoJ3g7QsIEKtpSATEDT0MyqsQ1PZmuFv/b5PA6+lxBxQNiA5HwTeXDR SEvtz6MNlLo++v06uUEfuKqVCpWO4b5OSgNauW+yX+B1iYpvaDCgAI4hJNjvXik0VjqR JuqWfdZO08y3TVsNR8G6n5FmvWl6BKFrzqFB0+kzM5yhywAD75eFB16IBwVa69NInjlI I8zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=E9WLqwwqUl33LNN+XA+CQqSaJBm7quL1Oyr9JUSp8bI=; b=uy6ax+IQGrMFOdAvvR2x6815S4W8yNaSNFnwzajY1d7lzPEEmavC/MQGgtvap3EXcl 3hnwK8VEJoTdV+550BabOz5mneuzH0PO2XbWh4Abds3gFYom4EqpKH0V1xktf6bJwL6u aaeTFPcM9rOxOnxuEfGO4O5gN8ZI9JSmRe95BWgerkiaxtPCAjSYPY5i/SQ/FVVEl6tw F61fc8oa0SYvCkKwrU5F93nzfMVzdSX8wyeL0CDTqCS3jpgv+Yd8xd+DlUxB6VE2jJN5 G+yxV2Jr8kLbjHIzq2DxVZBSQnWz3ke37i+R56r+WdFFJOGTOaRML8T+Xg3RR3BTGZB2 yVbA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si7291570pgq.545.2019.01.21.12.17.03; Mon, 21 Jan 2019 12:17:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728444AbfAUUPj (ORCPT + 99 others); Mon, 21 Jan 2019 15:15:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:55614 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728315AbfAUUPS (ORCPT ); Mon, 21 Jan 2019 15:15:18 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6A31AAFFE; Mon, 21 Jan 2019 20:15:17 +0000 (UTC) From: Roman Penyaev Cc: Roman Penyaev , Andrew Morton , Davidlohr Bueso , Jason Baron , Al Viro , "Paul E. McKenney" , Linus Torvalds , Andrea Parri , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RFC PATCH v2 12/13] epoll: support mapping for epfd when polled from userspace Date: Mon, 21 Jan 2019 21:14:55 +0100 Message-Id: <20190121201456.28338-13-rpenyaev@suse.de> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190121201456.28338-1-rpenyaev@suse.de> References: <20190121201456.28338-1-rpenyaev@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org User has to mmap user_header and user_index vmalloce'd pointers in order to consume events from userspace. Also we do not let any copies of vma on fork(). Signed-off-by: Roman Penyaev Cc: Andrew Morton Cc: Davidlohr Bueso Cc: Jason Baron Cc: Al Viro Cc: "Paul E. McKenney" Cc: Linus Torvalds Cc: Andrea Parri Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/eventpoll.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index e70d1ab64ec1..cceeff77bdaf 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1276,11 +1276,47 @@ static void ep_show_fdinfo(struct seq_file *m, struct file *f) } #endif +static int ep_eventpoll_mmap(struct file *filep, struct vm_area_struct *vma) +{ + struct eventpoll *ep = vma->vm_file->private_data; + size_t size; + int rc; + + if (!ep_polled_by_user(ep)) + return -ENOTSUPP; + + size = vma->vm_end - vma->vm_start; + if (!vma->vm_pgoff && size > ep->header_length) + return -ENXIO; + if (vma->vm_pgoff && ep->header_length != (vma->vm_pgoff << PAGE_SHIFT)) + /* Index ring starts exactly after the header */ + return -ENXIO; + if (vma->vm_pgoff && size > ep->index_length) + return -ENXIO; + + /* + * vm_pgoff is used *only* for indication, what is mapped: user header + * or user index ring. Sizes are checked above. + */ + if (!vma->vm_pgoff) + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_header, size); + else + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_index, size); + if (likely(!rc)) + /* No copies for forks(), please */ + vma->vm_flags |= VM_DONTCOPY; + + return rc; +} + /* File callbacks that implement the eventpoll file behaviour */ static const struct file_operations eventpoll_fops = { #ifdef CONFIG_PROC_FS .show_fdinfo = ep_show_fdinfo, #endif + .mmap = ep_eventpoll_mmap, .release = ep_eventpoll_release, .poll = ep_eventpoll_poll, .llseek = noop_llseek, -- 2.19.1