Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6763291imu; Mon, 21 Jan 2019 15:32:30 -0800 (PST) X-Google-Smtp-Source: ALg8bN7alHdXScRA5mYneEDBsK8cYVOl8lN+6IdWGqguiuqlexqUYsIRNqm8fyyRBDtUeGrXqQ4i X-Received: by 2002:a63:9f19:: with SMTP id g25mr29785029pge.327.1548113550681; Mon, 21 Jan 2019 15:32:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548113550; cv=none; d=google.com; s=arc-20160816; b=VehBLHmub8WocQ3i8gYrJj/KdOn7VhNWsobDU25l9S6Nt8sdtWsShsSjXhFwfcBTXD LZkYEQCFvqkvFW/PLlzjv+rmECm4x9sMQJdYjKI+QFsLi7UrGBMt6ZOJN8AUL6+53iQj vPceW2dqZefQd6AJUv44/I9RHZT5QPVogCJjdWNbsd0eSCD8RsbdQpC5YRxVCZ1VSGqa aUV8Yx8i1sTaib93298I4SsLvy+7WD81FgGPfR6csX0JcMzcGyykCAXtxh1nT65+deHy Z7Tp4CaAm+Br7TpiFwLDRocrrZpSyYlaQIxlMwXOA71xrbKMpHHeVfQ1UpGMEHJamfYp Cd0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=750ltZ8sruCtvwE2zLFBoFpEvNZ2Lx2tBMn9zU6ACfI=; b=RS0/kZIN4demqEqif135ZhbmmbFfWfvIWOdcTyPmRp9whW6NgCBzNkl0exFzzmNI04 ngCyODLFov4aEigaqufe6jM7pxJ5IFduvejO6bJGdwqka8pk3pikPDXru2T7rYd337nF Hsu3XbONAmf7k/SSQ+d8l/IztGzXwOgFDV8nLLJLOb3oePY4uLH07QKqgFWkIZEdYuSu 0LnMXUHUqIESX5zLwcv9qZyQEHJqsPfhkb0LsOcnNuvszb9oDiqRQzfBRKYnlgutu48S SJJDjKnas7BMMhWxfbSlceELydhIAQh7NJ2sp+xlMtvc/UyxtR+GrDNVaH0up8Iev0wv JTog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kH6gkEjO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b10si13258816plz.233.2019.01.21.15.32.13; Mon, 21 Jan 2019 15:32:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=kH6gkEjO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728018AbfAUXbJ (ORCPT + 99 others); Mon, 21 Jan 2019 18:31:09 -0500 Received: from mail.kernel.org ([198.145.29.99]:38952 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726027AbfAUXbJ (ORCPT ); Mon, 21 Jan 2019 18:31:09 -0500 Received: from sinanubuntu1604.mkjiurmyylmellclgttazegk5f.bx.internal.cloudapp.net (unknown [40.117.83.110]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 94B822089F; Mon, 21 Jan 2019 23:31:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548113468; bh=GPRUJnIB0OyzBbUFz04hJUGu7UnzF9PTVC/GUpLYalo=; h=From:To:Cc:Subject:Date:From; b=kH6gkEjOx5XHSJAFKsUCqv/+utj3yIBDtj7Hqv0VaoeTJ7nDZYgZDbFTR3gtAJRfr tMqvCg0ZmRRhZKqEGOx+XeM+fyvZ2IXsz6PEbvmer9lOdN9ah23+9y0wt72rNoouii Gzm5mkynCeekxRsggGNog1cj5rFGY7YGH+AMiE6E= From: Sinan Kaya To: linux-next@vger.kernel.org Cc: Sinan Kaya , Johannes Berg , Emmanuel Grumbach , Luca Coelho , Intel Linux Wireless , Kalle Valo , "David S. Miller" , linux-wireless@vger.kernel.org (open list:INTEL WIRELESS WIFI LINK (iwlwifi)), netdev@vger.kernel.org (open list:NETWORKING DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [for next][PATCH] iwlwifi: Fix unmet dependency error for IWLWIFI_LEDS Date: Mon, 21 Jan 2019 23:31:02 +0000 Message-Id: <20190121233102.13705-1-okaya@kernel.org> X-Mailer: git-send-email 2.19.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org There is an unresolved dependency as follows: IWLWIFI_LEDS selects MAC80211_LEDS. MAC80211_LEDS depends on MAC80211. It is possible to choose MAC80211_LEDS (y) but not choose MAC80211 (n) WARNING: unmet direct dependencies detected for MAC80211_LEDS Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] && LEDS_CLASS [=y] Selected by [y]: - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y || LEDS_CLASS [=y]=IWLWIFI [=y]) Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this configuration. Signed-off-by: Sinan Kaya --- drivers/net/wireless/intel/iwlwifi/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig index 491ca3c8b43c..74f0d0bbed34 100644 --- a/drivers/net/wireless/intel/iwlwifi/Kconfig +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig @@ -46,7 +46,7 @@ if IWLWIFI config IWLWIFI_LEDS bool - depends on LEDS_CLASS=y || LEDS_CLASS=IWLWIFI + depends on MAC80211 && (LEDS_CLASS=y || LEDS_CLASS=IWLWIFI) select LEDS_TRIGGERS select MAC80211_LEDS default y -- 2.19.0