Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Andy Duan <fugang.duan@nxp.com>
To:     Stefan Agner <stefan@agner.ch>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     Marcel Ziswiler <marcel.ziswiler@toradex.com>,
        Max Krummenacher <max.krummenacher@toradex.com>,
        "dev@pschenker.ch" <dev@pschenker.ch>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] net: fec: get regulator optional
Thread-Topic: [PATCH] net: fec: get regulator optional
Thread-Index: AQHUsZnSRnswizwjwEGgd4k/7MMsmKW6g0DA
Date:   Tue, 22 Jan 2019 01:39:44 +0000
Message-ID: <VI1PR0402MB3600576A0BE62C6363F93B45FF980@VI1PR0402MB3600.eurprd04.prod.outlook.com>
References: <20190121145847.30223-1-stefan@agner.ch>
In-Reply-To: <20190121145847.30223-1-stefan@agner.ch>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: a543299e-de74-4063-d671-08d6800a7c5b
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Jan 2019 01:39:44.2675
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3725
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Stefan Agner <stefan@agner.ch> Sent: Monday, January 21, 2019 10:59 P=
M
> According to the device tree binding the phy-supply property is optional.=
 Use
> the regulator_get_optional API accordingly. The code already handles NULL
> just fine.
>=20
> This gets rid of the following warning:
>   fec 2188000.ethernet: 2188000.ethernet supply phy not found, using
> dummy regulator
>=20
> Signed-off-by: Stefan Agner <stefan@agner.ch>
Thanks.

Acked-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/freescale/fec_main.c
> b/drivers/net/ethernet/freescale/fec_main.c
> index 6db69ba30dcd..c8315d880c8c 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3479,7 +3479,7 @@ fec_probe(struct platform_device *pdev)
>  	if (ret)
>  		goto failed_clk_ipg;
>=20
> -	fep->reg_phy =3D devm_regulator_get(&pdev->dev, "phy");
> +	fep->reg_phy =3D devm_regulator_get_optional(&pdev->dev, "phy");
>  	if (!IS_ERR(fep->reg_phy)) {
>  		ret =3D regulator_enable(fep->reg_phy);
>  		if (ret) {
> --
> 2.20.1