Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7229387imu; Tue, 22 Jan 2019 02:32:43 -0800 (PST) X-Google-Smtp-Source: ALg8bN7PShPaKrifJ7tkuXb5Egdn7GFzDFzBUJ/I2oJa+8j/D5cIGnPdVCXqHhIBMHBfc/n7nXnE X-Received: by 2002:a62:ca9c:: with SMTP id y28mr32884181pfk.236.1548153163067; Tue, 22 Jan 2019 02:32:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548153163; cv=none; d=google.com; s=arc-20160816; b=szLDJ/rRMx5m5mb9WmeHCNYmaRbD1p4ifHLYGuRvzxJTvV7UUCtPWtJJuByt1J9Ulh hrfCmT7xD6R1dWnZcFNwZbs65VzuqaiZR73RzBBq7TQvjgsL6XUX078FNLuTbjXkY6iB Db5qX4yCIHmRkTXnDuM44BBgWqsA39yH+m+46hhqk+WuFJlZK6tvZIn33B9Sj82BAfOf xgXXUzGev5/yqzfeYSrdjBvEkVS6tegmQS8NUXGUCpIA2J2zXY7jW9ZcTY89szgyzzt5 lmzO3yWD6LgNgwTWbmubyp6UjLGBwbIXLYshdWp/ATRRcvI3+C/fgCF3+cVbhyrqe8Ca q+Gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:to:subject:cc; bh=9DvF1PusHeLhXyj9sFlJNXdUsgwd2jbIZ7/jlcgAvog=; b=tkoMoLsI5oNM5Xxe0KazjvZDw/YRb23hiugAFxE7Z5BuVokTcWJ9nPGI6872PSgM/D K3cYmMNbOuAn5fSPGwh4iRGtjbfln8s9B4HPvIdgloZMw2F76nUIA70Gxqi6nN9ZsOki XUL7WUeU2iCuBH9hvDqrRejAW7SP7jUMhRVqK4ptKU1jjepoSnvJTGIHLfEKEy2c89p5 1P8OXax+0hrNHT4b7UfQEjlkBBSmNeNg2eWYpXzFCSOJNzu4UgcpKIEE+csnZuJXHN8b jASFjHl1ZSGBbg97oUUVKqJsQ5fBWnsZGYM1B5/9LdWnuSVpFmKzGku97Q/7OD5jUsia We7Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s11si16078109pgi.324.2019.01.22.02.32.26; Tue, 22 Jan 2019 02:32:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727692AbfAVKaq (ORCPT + 99 others); Tue, 22 Jan 2019 05:30:46 -0500 Received: from foss.arm.com ([217.140.101.70]:50282 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726683AbfAVKap (ORCPT ); Tue, 22 Jan 2019 05:30:45 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 632F8EBD; Tue, 22 Jan 2019 02:30:45 -0800 (PST) Received: from [10.1.196.42] (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id EB4323F6A8; Tue, 22 Jan 2019 02:30:43 -0800 (PST) Cc: Sudeep.Holla@arm.com, rafael@kernel.org, linux-kernel@vger.kernel.org, zhangfx@lemote.com, wuzhangjin@gmail.com, stable@vger.kernel.org Subject: Re: [PATCH V3] cacheinfo: Keep the old value if of_property_read_u32 fails To: chenhuacai@gmail.com, gregkh@linuxfoundation.org References: <1545207363-7402-1-git-send-email-chenhc@lemote.com> From: Sudeep Holla Organization: ARM Message-ID: <0f1a742c-9123-e615-6abc-bc6325a7644c@arm.com> Date: Tue, 22 Jan 2019 10:30:42 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/01/2019 00:51, Huacai Chen wrote: > Ping? > > On Wed, Dec 19, 2018 at 4:15 PM Huacai Chen wrote: >> >> Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF >> property_read_u32 instead of get_property,read_number") makes cache >> size and number_of_sets be 0 if DT doesn't provide there values. I >> think this is unreasonable so make them keep the old values, which is >> the same as old kernels. >> >> Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number") >> Cc: stable@vger.kernel.org >> Signed-off-by: Huacai Chen >> Reviewed-by: Sudeep Holla Looks like this slipped through the cracks during holiday period. Wait until Greg responds for a week, if not please repost as it may be difficult to dig out old emails especially the ones during holidays. -- Regards, Sudeep