Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7256813imu; Tue, 22 Jan 2019 03:04:11 -0800 (PST) X-Google-Smtp-Source: ALg8bN5nJI/Pv/+5XVRLL/DTwvyDtNIrSunCYQRiEVrbB2PcmUhRKA76oM0RR/c+GQCy8439xzxk X-Received: by 2002:a62:d005:: with SMTP id p5mr33193381pfg.175.1548155051928; Tue, 22 Jan 2019 03:04:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548155051; cv=none; d=google.com; s=arc-20160816; b=unJdkghJ3+DwlIiuPbKwhVvw2ZIIH6qUuVvVVMY+PMRKMJN4901kFJ+5PGzNONvkEz tbxH+l/YWBGlVNjSd3uqQxmTTgjJ0ZSmVsEpDKWWBZFX/bRkhvh9rr27wnhDvFrMEkKU NCMym0K536b/vjzOghaRPjURXNoFeV8TXY9FDsgQz20wr0ay6kgPajto25a7Mo3vrFwB P616yz7rUFAnpurDlfrNiSLN04+YOtOayLttOriuDqky1rd5ZMyd2ITmBMeWBtZ0mAlb gF59mjBj3/n+ITbdm70LLwtSCMDoVeYSW8c9gfDhC44mWuL3HkXsfwehUI7KFqmEZCsG evcw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=qL/QYM8Xwhvy9g2HpnW5jW1aVWDF2Ywaje3busb2t1g=; b=sM9cH/A+ativVpDHQuokPl7xWNGHaxF0jWy2hdyUGpe8/SULkTO+tE/evtTSS/Wm6E I6dm8YaiqGQyvMG8CHUdDPMnf5G9B5F2nZy4nkwaWDoEr/jMSShQch1NyUnOU5BuwbIa m4HwH05yui0MFrsrjDI5T1Q+fvCfJL6nb4SI399kpinPpCNMHPuS7ewEYWB5kNhDamzd 23UZC58JuJF4TlBGxE9mHxJiC1gAbCqdd+iym3m8TfNEK/GWAcP4dFJp4deO/adsV0BP YAsA/QAUvtd7zuW/n7kn1MFQzzPUIh3t38+9yy7caANoRORWcGX7j0bKjgkf50fHvF4C gdGg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nP5a6qBv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m188si14773878pfb.266.2019.01.22.03.03.55; Tue, 22 Jan 2019 03:04:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=nP5a6qBv; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728067AbfAVLBj (ORCPT + 99 others); Tue, 22 Jan 2019 06:01:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:56578 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727048AbfAVLBj (ORCPT ); Tue, 22 Jan 2019 06:01:39 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F216420879; Tue, 22 Jan 2019 11:01:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548154898; bh=TF88CO53nMwZgCdVd6XfDcmudxGfuXMQ5I8RmDQpPLE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nP5a6qBvCTx1URIPZxuygVg+ouG4vYSJNBQKk36TxPqkz68CX62jPpVkocvTsXMTQ HzliX7RPGtKEBCBoj9lcLd76A/0j551fRx5j2Pd5rvPr+4Lb2UzSvaV/5BkNMRmYT3 HXFTx/LKobCqhItmw+k1bgj+YPsNdDO5o0PaMgTg= Date: Tue, 22 Jan 2019 12:01:36 +0100 From: Greg KH To: Liu Jian Cc: xiubli@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] driver: uio: fix possible memory leak in uio_open Message-ID: <20190122110136.GD21034@kroah.com> References: <1546954723-197902-1-git-send-email-liujian56@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1546954723-197902-1-git-send-email-liujian56@huawei.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 08, 2019 at 09:38:43PM +0800, Liu Jian wrote: > If 'idev->info' is NULL, we need to free 'listerner' "listener", right? Please fix up and resend. thanks, greg k-h