Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 Jan 2019 12:08:09 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     rkir@google.com
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] drivers: platform: goldfish: goldfish_sync: add a
 driver
Message-ID: <20190122110809.GB1004@kroah.com>
References: <20190109021112.5836-1-rkir@google.com>
 <20190109021112.5836-3-rkir@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190109021112.5836-3-rkir@google.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 08, 2019 at 06:11:12PM -0800, rkir@google.com wrote:
> From: Roman Kiryanov <rkir@google.com>
> 
> The Goldfish sync driver is designed to provide a interface
> between the underlying host's sync device and the kernel's
> fence sync framework.
> 
> Signed-off-by: Roman Kiryanov <rkir@google.com>
> ---
> Changes in v3:
>  - Removed WARN_ON.
> 
> Changes in v2:
>  - Added a missing include (mod_devicetable.h).
>  - Put in one batch with goldfish_address_space.c to avoid merge comflicts.
> 
>  drivers/platform/goldfish/Kconfig           |   7 +
>  drivers/platform/goldfish/Makefile          |   1 +
>  drivers/platform/goldfish/goldfish_sync.c   | 827 ++++++++++++++++++++
>  include/uapi/linux/goldfish/goldfish_sync.h |  28 +
>  4 files changed, 863 insertions(+)
>  create mode 100644 drivers/platform/goldfish/goldfish_sync.c
>  create mode 100644 include/uapi/linux/goldfish/goldfish_sync.h
> 

Please get this reviewed by the sync subsystem maintainers to ensure
that you are using the API properly, and that this really is needed.  If
it is needed, why is this a goldfish-only type device, why do not all
systems need this?

thanks,

greg k-h