Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7360360imu; Tue, 22 Jan 2019 04:53:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN5uR3dvpbBR916w7xGzvRMOsxUD/rlXeai95KaoiW7iSQLlMHeowSKtk3+wpAKFdbiOtWrJ X-Received: by 2002:a17:902:bb86:: with SMTP id m6mr34531813pls.315.1548161599987; Tue, 22 Jan 2019 04:53:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548161599; cv=none; d=google.com; s=arc-20160816; b=BBXifx+ljw8NdD31DNd+vT6xUIh7HgUxTAXwHSS/8Y32h+WPacLtbU8VUOzQUs5zXx ScqB4gPL9yTs3Al14LI4LxFMFW8a0sQ+V4/BLr1xQw4O7E5Nb61VwNmv2lUrpzh+07+/ 6OEypj7DWDUgL3o1uFRW+3VIzT/4KwCQaa5MJFiuqmwcSfw7AD9emKFiPZSHfS9ntxzW MYMHqOdJfS9O4qUEHoNs21PjhO5Qk0VQlXtn4PgGBC3BbvdDLfLMxJkgherQYhJ6B+4H 6fskLP5rU0hhKmvzthj2n9ZowuN0ndruYjTv2d4KjAYdDOWPOxyRqZWn3iz7r7jGdJzV uoAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ndFHnUOGW3SsCu8b0oAHQJc2i7UVoO/e4lcNnjiRxas=; b=DtQl9wNxHZbCuCNw3z73TbW1SPM7KztqH6EorsdSJUfePvHzeAofZi4veLBacQkRQ0 2PD8agcuW3mAbykpFWruq4cjdLMsf+49so4dL+fPbwHa2AgjzvHufB2NKwK1UllUZoEn 5kOdQ36ZePGps6LTFSsXsjIsKAfDW4xwbK+Udn1POZ0j/b3qUF3gb3mxr0wijFUUly7w 7+jqd+6UcdsaZ76qHv9CcoceYVqCC6OpE40LrCpvqOtCdbmvjcAYbYTcHzOV59uLEzy4 aYPgwUgwkL88CM1pnC3OW7X3EWSeGnJnUu5JOfIH+TeiKZgdGpICJuNFftBLfrKdnKfF m2+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUlnXdHg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id cb1si3363054plb.37.2019.01.22.04.53.04; Tue, 22 Jan 2019 04:53:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=iUlnXdHg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728406AbfAVMvy (ORCPT + 99 others); Tue, 22 Jan 2019 07:51:54 -0500 Received: from mail.kernel.org ([198.145.29.99]:40126 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727936AbfAVMvx (ORCPT ); Tue, 22 Jan 2019 07:51:53 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9B2DE20855; Tue, 22 Jan 2019 12:51:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548161513; bh=WNzRiRpLCAs94iE/Ig16FXpeDECydSfGTxbHfT7WH6w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iUlnXdHg4AGkrYdAM4q89FI51NEYtEAQF6iezH5jhzR3JMVgl9Q3yjfKcgPy+tYaA hYWNo2Nr14aqAcftaygXq1fQ9VXzxbEiTYH+73iEPR7nbf7bFQnmXSc4f8vGdnnC7q bbziiuYibRFrQXbEpi3LzoAo8RR/arfxOZi88BsM= Date: Tue, 22 Jan 2019 13:51:50 +0100 From: Greg Kroah-Hartman To: Huacai Chen Cc: "Rafael J . Wysocki" , Sudeep Holla , linux-kernel@vger.kernel.org, Fuxin Zhang , Zhangjin Wu , Huacai Chen , stable@vger.kernel.org Subject: Re: [PATCH V3] cacheinfo: Keep the old value if of_property_read_u32 fails Message-ID: <20190122125150.GA15913@kroah.com> References: <1545207363-7402-1-git-send-email-chenhc@lemote.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1545207363-7402-1-git-send-email-chenhc@lemote.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 19, 2018 at 04:16:03PM +0800, Huacai Chen wrote: > Commit 448a5a552f336bd7b847b1951 ("drivers: base: cacheinfo: use OF > property_read_u32 instead of get_property,read_number") makes cache > size and number_of_sets be 0 if DT doesn't provide there values. I > think this is unreasonable so make them keep the old values, which is > the same as old kernels. > > Fixes: 448a5a552f33 ("drivers: base: cacheinfo: use OF property_read_u32 instead of get_property,read_number") > Cc: stable@vger.kernel.org > Signed-off-by: Huacai Chen > Reviewed-by: Sudeep Holla > --- > V2: Add Cc and Reviewed-by > V3: Add ChangeLog Sorry for the delay, now queued up. greg k-h