Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7414221imu; Tue, 22 Jan 2019 05:46:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN6SBpZB0sOUqPUDuMD/Ss39Xet1bRuhMZAsYuqfD565x/lHVHOS1/BasPl3js5E835yNBxq X-Received: by 2002:a17:902:47aa:: with SMTP id r39mr33980956pld.219.1548164819247; Tue, 22 Jan 2019 05:46:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548164819; cv=none; d=google.com; s=arc-20160816; b=ObwF8tj653KixeKXViZT+be6k75jlzHxPTJZtZlCEBMfW9S08Ah/pHAcE9iOptERZa UKDGE64CHsjb/SeHvai/k1GBxnU5c+DnOPkwU0QorZEwMXrnJ9ppwc2m3WUXiq6pyOsv djXPVdoH8HkY/ib4t4dRRBUed7Gzc3EdjUA8uTtYrVda2oJpn9cTnkpDUr1V5EEu62Mk iWaG4LHvRpXswUBP9zJJEJ6w42t7tz4diz957c0BRbeq8hfor9WFsuwsQ/BXOxg+cS/Z TcJiXM92rqHJ8jWVZGdYNCkSiYsszzz91rBlL0lq9bwAN/6wP6ayttFMPiDl++pYJSLE fyng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=/rEntjk/fJ4oHEuNF9JD18gQfFuD3y2ZK8grEV6Gy5c=; b=ccUj2dzyV2IpvXelm5LwYYqnK9PWaFwjefiDvy3FsTD6WLYFnVYefR+rYoX3o9FJQC nbm075mhusgJX1szeXDcWEtwhfHi9itaPZW7C1HPVYp3JQNiUGBeDy7HNGAkDrs60jSk vwNSYXlqMdPm2CkyHElN1sc/5Otl+3BKFWY4IymVoJe9qhjz+lA+f4qB2z7pOaNkb2AT ufeqGxo+wZGeK8nAzFWDGj7QAHgnIpYh4mh/KPg/orN8fvoHZNtqamUFKGE7qic01SDq V4oVwzGvTreORwlefvkMe2yqFos5Ps4jxPVHld5DSnt+RalHR1Y3Lq3extGZGd4F4gl0 4I9g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HJhMfuVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j2si15829698pgb.55.2019.01.22.05.46.43; Tue, 22 Jan 2019 05:46:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HJhMfuVs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728644AbfAVNoq (ORCPT + 99 others); Tue, 22 Jan 2019 08:44:46 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:33191 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728463AbfAVNop (ORCPT ); Tue, 22 Jan 2019 08:44:45 -0500 Received: by mail-pg1-f194.google.com with SMTP id z11so11112911pgu.0 for ; Tue, 22 Jan 2019 05:44:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/rEntjk/fJ4oHEuNF9JD18gQfFuD3y2ZK8grEV6Gy5c=; b=HJhMfuVss5GLAQGWPmKSfbbRV5EoMZ5ATQ24HNwhz2uGfuGylPYFBqPebqi4ODD9A7 pwzV8QB3hK355lcPGo5py4t95syqxJ3VJ3fj5d3lWKRXLGcVYIwfEdslWW4PKreiaLAu qxpGsCV9/LNpKrEs++eGWCDZfwI48QdY+EqmVjKLAvUbY7A5CcTDiF03muRtXzCj+wlA 1lgExy/RvmJtJD+7P5xxEYtC1N6cxFn5h9sM22de+b//3ZpCbUEWkdPj7aXXTbWnyYA/ MXz91mnDHruAl9Eu0pJnHXuh845XEZ+dD8434b10wAhdE/XXcYJ4750X62HaA75SoLlO obHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=/rEntjk/fJ4oHEuNF9JD18gQfFuD3y2ZK8grEV6Gy5c=; b=EglhsEhoZrErUoB+vbAE0I3dAdXDNMgZMzskomXrt9PvdE38us8gSzh5u7S4EKdWMO peO6BGK+VZZ2cbJfZa3AkbcMyJgbbcjPgxw1Q2rguRaUZ45xYRZdhKXIJYUHUOgAROzK SdXaMX9ra+eIKH8ujV8KwfkLRMrxl3cWzqvAVYeecUlP7aDm/ceF+fixbIfvBMIFayoO PUbklZfERKQMvHam9npFYQOO/Brcui2aQwCpy+x79X/PqzxfRyxJKufy1bnI0N2HlhlZ 0HOaW5NenAvPl8/EZzh0iNqxLG22ZD4B0M+xb4us6P2zeQm/ZlS6hnylEkARfIOZqwBX wqHw== X-Gm-Message-State: AJcUukcxKv49ENQtTGI7LmzCcbS8PA87t19Q7tv7IU0oEhz90NQREyGB FZ6kS9bus1xryonYZ5sNjEs= X-Received: by 2002:a63:7d06:: with SMTP id y6mr31719543pgc.171.1548164685211; Tue, 22 Jan 2019 05:44:45 -0800 (PST) Received: from hydra-Latitude-E5440.qualcomm.com (blr-bdr-fw-01_globalnat_allzones-outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id h185sm22474067pfg.143.2019.01.22.05.44.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 05:44:44 -0800 (PST) From: parna.naveenkumar@gmail.com To: arnd@arndb.de, gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Naveen Kumar Parna Subject: [PATCH 2/2] mbcs: add .owner to mbcs struct file_operations Date: Tue, 22 Jan 2019 19:14:02 +0530 Message-Id: <20190122134402.26653-1-parna.naveenkumar@gmail.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Naveen Kumar Parna Without ".owner = THIS_MODULE" it is possible to crash the kernel by unloading the mbcs module while someone works with the file. Fix this by initializing the ‘struct file_operations' ->owner with THIS_MODULE. Signed-off-by: Naveen Kumar Parna --- drivers/char/mbcs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/mbcs.c b/drivers/char/mbcs.c index 8c9216a0f62e..0a31b60bee7b 100644 --- a/drivers/char/mbcs.c +++ b/drivers/char/mbcs.c @@ -50,6 +50,7 @@ static LIST_HEAD(soft_list); * file operations */ static const struct file_operations mbcs_ops = { + .owner = THIS_MODULE, .open = mbcs_open, .llseek = mbcs_sram_llseek, .read = mbcs_sram_read, -- 2.17.1