Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7551637imu; Tue, 22 Jan 2019 07:47:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN4PpytkL4SplhQ/ngYFIdIZ4GQQ2iGLFy4FONT6oC6oLWLTwCZsXDdktzi0GneUA7E8vjam X-Received: by 2002:a65:6094:: with SMTP id t20mr32163217pgu.285.1548172064298; Tue, 22 Jan 2019 07:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548172064; cv=none; d=google.com; s=arc-20160816; b=cCfY6EHiRJrHuLGh7IOpdfCYqr3+46a6Y6op1vLzAPB7q6XBEishdJoRoTrfF/Vc// +zupIF9lQEhwGotI+2kAw2F+lPozTm8viRS10eXtXNymjS7XfPseslqBotQM/gccf0Jh PhaU+Bi+s7yyjrtDNvsfA94ivOF7oMsTb7h5nn17CMTeGWdelC0ipxyd/bTfFFGikrXY NQYDIDH2PggsbE6EIYl+5iunjuWmcOqh/goSgs1sXGDLaCY66hL7cbVaswWwf8oZZMkj Ze2WzGN1+OEFAnBt2CfLOrXwl24QCeaTkWgz8FKF0E2MBVh8qydlyWAF1LKkKMheyyie Yytg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=7AXTiJ+PI1paWxcCtGYrxQmtleuHLj1fKPHB01K/gow=; b=XdjgewzKc5unSUSjXZWZsueLvdtA2pjGDsFhblnIQOAvOFDUjqXYuE7/aD8VUxSIZK tBT6oy7dG4rfW4CuLaWFfnuIM0dL4dxsrQHACQLijXZ1jojKQQniU6Hw2V1uBybrQxET feNncTO/oVE7tFPLvWebCEbkP1vo/6+Ge5+tDTTw85JjRN9x4JUWTZMBeO3dG4PXVa7C eWrpODmzLCzRtWmNqCJbItMZ2A61SMbvdB3Td7jabj6tuKu9a9f/qCpixLBWB/6xBpe9 gkQDjRIonW0x9tibSDm0mov9h1elPxI5Nuw+rAfFUOn2OAJdQUBHchiE7iaaThwEcMyo ojqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=D7GFl0XG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 31si2005340pli.438.2019.01.22.07.47.28; Tue, 22 Jan 2019 07:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=D7GFl0XG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729188AbfAVPpv (ORCPT + 99 others); Tue, 22 Jan 2019 10:45:51 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:43945 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728683AbfAVPpv (ORCPT ); Tue, 22 Jan 2019 10:45:51 -0500 Received: by mail-oi1-f195.google.com with SMTP id u18so17724999oie.10; Tue, 22 Jan 2019 07:45:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7AXTiJ+PI1paWxcCtGYrxQmtleuHLj1fKPHB01K/gow=; b=D7GFl0XGQp8AcNqsc6+0iHCU7aVrEtD3461MuJj6Lsu5p9X38pfWSxipkcBr+1wKYg 8YXEG+Xa5r/V/zDw64DQe10DzpQfSbXX0XL6KqPzGFOZ0CB2TukH9u9BRdAVzo4ERB73 i6jWna5hMQnHZmnYghl6DTxblmgQVGI2piQ/BnGqI1ab7KUurV4Zdj5Jlp9Zzc8UQLmp JxIkHGuwNwYEcjAw/woEcAR/Vjv2pnpf4aT9UmJ7YTQaKnvMqBT9T9mrOA84Fiep36Nj vLB3uoLaI/0Dfs3gVjbzqzHTDlkMf2WYh5oI4owhxqEx17CL7Avrlas5rsJ/vq48eMcX 11oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7AXTiJ+PI1paWxcCtGYrxQmtleuHLj1fKPHB01K/gow=; b=bKCZAJ/hv5q5vjPtq5fQsGAQTIbY9OPCvYuJP1s86BDLf8pjTROxb+iVyoPSDcpWQa vCfjBXLtAQCalFnvVWxJH+OEHfSj5oArkWgxH94tdfDdOjp8ipVzXM/nVV9K+jIPYz/B 4civez+xFCB8iGAgwIJAWbr9e4O1JzYSe2dMgryzkI5dOwe3fKffeM6FUm6m7VH1/wC7 JAm0JO6CMrTO0wYtblM4PqLGqi2CgeN5luWg/r57KsYgUUt8X8SN2WP9Wd6EMRCio7QY PoNM/eNShM+pcRiPLcB0PK7wobzjEc+uK5EEc0BUQHT48uAYd1QfIgwB7EFqkTOR3aBH UUYQ== X-Gm-Message-State: AJcUukcawgzN/WPmVvvv/W7mYPTBDGJ7Kxo1yF5rKcThGYjRbbhJ1jZa oQnxkMXEwtTgXGByIKvP7zs= X-Received: by 2002:aca:eb0f:: with SMTP id j15mr9007980oih.110.1548171950476; Tue, 22 Jan 2019 07:45:50 -0800 (PST) Received: from [192.168.1.112] (cpe-24-31-245-230.kc.res.rr.com. [24.31.245.230]) by smtp.gmail.com with ESMTPSA id y2sm6675064oto.49.2019.01.22.07.45.49 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 07:45:50 -0800 (PST) Subject: Re: [PATCH] b43legacy: no need to check return value of debugfs_create functions To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Kalle Valo , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org References: <20190122152151.16139-31-gregkh@linuxfoundation.org> From: Larry Finger Message-ID: <451b54fb-0ef0-ce6b-71e4-39ba781b5a94@lwfinger.net> Date: Tue, 22 Jan 2019 09:45:49 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122152151.16139-31-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/19 9:21 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Larry Finger > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: b43-dev@lists.infradead.org > Signed-off-by: Greg Kroah-Hartman Acked-by: Larry Finger Thanks, Larry