Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7551639imu; Tue, 22 Jan 2019 07:47:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN4hC3Y3HIxq2Qomd+dPb7UqnrDhx+oqDhkCKhI/zQbh0/FIibnN5K8o8xU/lmqrnKBrHDCW X-Received: by 2002:a62:1212:: with SMTP id a18mr34978883pfj.217.1548172064306; Tue, 22 Jan 2019 07:47:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548172064; cv=none; d=google.com; s=arc-20160816; b=FLQdnm2JJBwcJeWRTKUMJUws4D6+3apnbaASJdZDWIdQ4ywTFCj8sOmZMQ8jgGWdHk H7xtsXjwkmmKX6U6sqCyB7+9C5JKLkg9FtPO6a4l5HQP6IqTtosuUOK5Rn+d3tS8zDWL UUFcVA16PpR1Bz8MLtbfD/f8q3EJXGh9nlxdyQ5ZQKnPZ+WZA/Y/wXUn/7MLFRb29fJH DEIFJXfPWdVOKLIGwOFqSDd28jfzTXXxOfLHu3s7MxSZ5o8ejoHsQ7/iqjs71pZVNtXx Ab1W0aLpktcJGZzn2Y3NfejYvwDXowLdqdHc4nd8kezeWJWIuer8k3jRAf4vwedk5B1S aKdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=jySj76otXaOTOM3jZMZUQKaNajoL056bBFNn8sS0UsA=; b=Ipa0qEqh+EQP54jQ4qumPSH/QUmj4/yaYiful70NA6FY8hYy92bNdjsYch22EAX2xt gtw8I4RakxBEiPhweYOMmOf7KOwbMMr8ynwcqwdBHvENAhoVFcgDN/CtGE7hXdm8CFHl GU2LZtw4W7IqIt0ys8x2QHVh0v4+VUjPOEfQN9mJecmEQTT0SOsDGTlp0eUFyVktYWqK JmlFOoobA2+6W7YXM9UHopyDG6S5R2VD+qRfhCwwoxqDgK8kmiSh1ljycFUDFyruD64E JdclMoBWCCoMyi35dFF53K/RNr8ir7wtD9eP85iDnj1HIkHQw3ZyOz6kvc0OlwYqiMpN T8tQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=g727yUE8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u137si15798846pfc.133.2019.01.22.07.47.28; Tue, 22 Jan 2019 07:47:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=g727yUE8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729098AbfAVPoj (ORCPT + 99 others); Tue, 22 Jan 2019 10:44:39 -0500 Received: from mail-oi1-f193.google.com ([209.85.167.193]:35399 "EHLO mail-oi1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728633AbfAVPoj (ORCPT ); Tue, 22 Jan 2019 10:44:39 -0500 Received: by mail-oi1-f193.google.com with SMTP id v6so17764200oif.2; Tue, 22 Jan 2019 07:44:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jySj76otXaOTOM3jZMZUQKaNajoL056bBFNn8sS0UsA=; b=g727yUE8A2nSQzRd7uw1KsHFd6KYx0dPQ+wd/RYy5DKg0nQn/4zcaNbj2/ZhRMrdKw hwAt31ShcD0EdxGjvLygy8jlikmMbY6Y8rrG1hVm4TxNuk5L7093MN6dUhSvguCFjtV7 Rd+p4r0yQi+UMNX7X8/ne0IR5DfECOCHUtZ4wj4oEs8cAYexEDnDLr7dbQx+1sCvzYZz NfJR8VPETFi0Ja8/l7YAs1FTxkgzWkWDBjTA53AD0HfsnyqNZ9m/IqtfOqBW3uyx2PAn vNrPcoRX2Fq28xh11qF++JCdr9Xsh04nWxjS1yKexFqycxcLcCy+g8BVi2PX+JmRq0rk x8BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jySj76otXaOTOM3jZMZUQKaNajoL056bBFNn8sS0UsA=; b=FgqrEQFj0WJxu27Ae2N/Xpaw160T/DGb6tbgHy4KkXMRALVQ09CgtZ7BahKyf3gfVm HU97KT2Z1TIhPzTOhQkxXghHFCb0tNriAIRt/yQw94MUdoeQWuT7TbMR792yPfJVy+3w dSTNRotG4ld6i8AvCqYOoC4ZWkO/j29DY7HXTFuTvxGnIsNxj7wcmzQDNjFAtFtLmjbb xrXswyjdDcVfXtVp5HS1IdcRzK9tRYL67BMVIy9INqnC1F1it8OcixijJK8NXzuwQhTK iBvbNbACIbIspAyoOZaylS/SlxDS4bSr5LZ8neyfdPhW+gVX2mHfD41Okq8uGEQaYrW1 yfpg== X-Gm-Message-State: AJcUukdePnzhzTFPyMtCGznH4GoaCheNhAdMt8JSPW48TuR3vkNIbA6d EDTyTMU5fxQGzucC1VH3qPzh0P+z X-Received: by 2002:aca:720a:: with SMTP id p10mr8218016oic.169.1548171878586; Tue, 22 Jan 2019 07:44:38 -0800 (PST) Received: from [192.168.1.112] (cpe-24-31-245-230.kc.res.rr.com. [24.31.245.230]) by smtp.gmail.com with ESMTPSA id c132sm7535850oia.41.2019.01.22.07.44.37 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jan 2019 07:44:38 -0800 (PST) Subject: Re: [PATCH] realtek: no need to check return value of debugfs_create functions To: Greg Kroah-Hartman , linux-kernel@vger.kernel.org Cc: Ping-Ke Shih , Kalle Valo , linux-wireless@vger.kernel.org References: <20190122152151.16139-34-gregkh@linuxfoundation.org> From: Larry Finger Message-ID: Date: Tue, 22 Jan 2019 09:44:37 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122152151.16139-34-gregkh@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/19 9:21 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Ping-Ke Shih > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman Greg, Please change the subject to read "rtlwifi: ...". Otherwise the patch is correct. Acked-by: Larry Finger Thanks, Larry