Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7555208imu; Tue, 22 Jan 2019 07:51:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN74fVMQsTdUgcaBvgLPkVOyJie87hqi3Ylcd+5GJtbH/VD6SbCHMSOyPzYjqrUICvJZa2oK X-Received: by 2002:a62:1d8f:: with SMTP id d137mr33625130pfd.11.1548172264472; Tue, 22 Jan 2019 07:51:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548172264; cv=none; d=google.com; s=arc-20160816; b=M/XIVRm6AeK+4SVE3ktKts2Eb0elP9yy/JaLMlxJJp4wQhZXukMfrCqFLJKm5zmgP5 SlkAemlnh3BpXnbr2dZHpIgf+SrszfNO24LvwXNk8yshCCcu54KhV58xy2XphWmMks6M ZribLRRkqxBKPCtyWsrQFey8gmK1TccKzPw71tBpXuYY3JODO5dKWAGv7SkN9DtMeb8V U4s+KDfzCSqn22LJeEysPuLCwuKJJLx0V0KfMCqwvRy0vIGxzY5RWCmOj56E2G0yGbj8 6p8GE84HCnpMqZODHjqXzwrFR4W5hsAQnGrLh6M1ziNMxVYQ0IHmh91o1CFhq273xgii DKig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:dmarc-filter :dkim-signature:dkim-signature; bh=CLlsB/dNly4lph9B9J4oZ1L6jL88kbMO9HZ12IoPv9c=; b=UynkjDSj97uI1Zkf3Jwuy+FRaP53FQBcpDvJdoLh/yggdKAPdH+AJVw+SmqBwEP7Bl 4YvouP5HWZmoKP8JCQuQxwfneCk0b///1FSMVSdIE6kU2l5sOrFP2wkekF3FO7jdEtD6 pQO0whK6/p+mw22oo5QDo0xO1pLIT5glqCfYh6bOMXVmy/AP1Dmxd5ZTR0aczLY+xKgd Ag5hniDguyTrXWW010A663rzg4PukIWX3MTEVk66NDVq5/BriXCa3p7XQsO2Sc57GAz5 231WM2SO8d/A60fQ0SOpyNor1FmMok+JTXGh5qJMDl5hUwQBsYAiipWq+vkE57wC5oap 4ckA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DTudGlb2; dkim=pass header.i=@codeaurora.org header.s=default header.b="lAl/vyo/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c136si11456552pfc.141.2019.01.22.07.50.48; Tue, 22 Jan 2019 07:51:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=DTudGlb2; dkim=pass header.i=@codeaurora.org header.s=default header.b="lAl/vyo/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728966AbfAVPs5 (ORCPT + 99 others); Tue, 22 Jan 2019 10:48:57 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:58194 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728664AbfAVPs5 (ORCPT ); Tue, 22 Jan 2019 10:48:57 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id B441B60712; Tue, 22 Jan 2019 15:48:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548172136; bh=c3bqGCblV9YH62iQvi4K1pj3MExdGL1OvCIKkQ896Tk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=DTudGlb2NQDVL7zVHuUnUoQ2f7qn/83KBhZl09V8SL19zhPRq2GZufgrVLLlGroAd xFL235DGQE7cOgjqRAHwv8xzB0azTTTadeCW5ckAk5rKnV8L4mNZFEHOlKUGG817P0 HvQZqJxm4TPKjySurlS+XHjSDdkiX4TuoguxenKQ= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 0F286601B4; Tue, 22 Jan 2019 15:48:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548172135; bh=c3bqGCblV9YH62iQvi4K1pj3MExdGL1OvCIKkQ896Tk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=lAl/vyo/NXM3q8BE3dFZLatijjUCQzVyYBzExLtEJudNjoNfzpJaM+BPIF0WO1DlK PM4ALgDtMwWyTJufAm4UrKd0VKATJZbhkXKYWlsGQPGxxCpmDUnNsGxMuiAqatawEa lRib/F4v7vVUJJYrItqxYKZZjbvcsEwY9NGmDt+s= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 0F286601B4 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Larry Finger Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Ping-Ke Shih , linux-wireless@vger.kernel.org Subject: Re: [PATCH] realtek: no need to check return value of debugfs_create functions References: <20190122152151.16139-34-gregkh@linuxfoundation.org> Date: Tue, 22 Jan 2019 17:48:51 +0200 In-Reply-To: (Larry Finger's message of "Tue, 22 Jan 2019 09:44:37 -0600") Message-ID: <87r2d4n15o.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Larry Finger writes: > On 1/22/19 9:21 AM, Greg Kroah-Hartman wrote: >> When calling debugfs functions, there is no need to ever check the >> return value. The function can work or not, but the code logic should >> never do something different based on this. >> >> Cc: Ping-Ke Shih >> Cc: Kalle Valo >> Cc: linux-wireless@vger.kernel.org >> Signed-off-by: Greg Kroah-Hartman > > Greg, > > Please change the subject to read "rtlwifi: ...". Otherwise the patch is correct. I can fix that during commit. -- Kalle Valo