Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [for next][PATCH] iwlwifi: Fix unmet dependency error for
 IWLWIFI_LEDS
To:     Kalle Valo <kvalo@codeaurora.org>
Cc:     Luciano Coelho <luciano.coelho@intel.com>,
        linux-next@vger.kernel.org,
        Johannes Berg <johannes.berg@intel.com>,
        Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
        Intel Linux Wireless <linuxwifi@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190121233102.13705-1-okaya@kernel.org>
 <ef50896ee3ecc895c72a9fbdedca65ac6433fef2.camel@intel.com>
 <d00c99a7-423a-9a70-5f50-f95c5d044f85@kernel.org>
 <87munsmztb.fsf@kamboji.qca.qualcomm.com>
From:   Sinan Kaya <okaya@kernel.org>
Message-ID: <7baaaf76-7f96-cd1d-2a8d-e6c4342c10dd@kernel.org>
Date:   Tue, 22 Jan 2019 11:20:54 -0500
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <87munsmztb.fsf@kamboji.qca.qualcomm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/22/2019 11:17 AM, Kalle Valo wrote:
> Sinan Kaya <okaya@kernel.org> writes:
> 
>> On 1/22/2019 5:15 AM, Luciano Coelho wrote:
>>> On Mon, 2019-01-21 at 23:31 +0000, Sinan Kaya wrote:
>>>> There is an unresolved dependency as follows:
>>>>
>>>> IWLWIFI_LEDS selects MAC80211_LEDS.
>>>> MAC80211_LEDS depends on MAC80211.
>>>>
>>>> It is possible to choose MAC80211_LEDS (y) but not choose MAC80211
>>>> (n)
>>>>
>>>> WARNING: unmet direct dependencies detected for MAC80211_LEDS
>>>>     Depends on [n]: NET [=y] && WIRELESS [=y] && MAC80211 [=n] &&
>>>> LEDS_CLASS [=y]
>>>>     Selected by [y]:
>>>>     - IWLWIFI_LEDS [=y] && NETDEVICES [=y] && WLAN [=y] &&
>>>> WLAN_VENDOR_INTEL [=y] && IWLWIFI [=y] && (LEDS_CLASS [=y]=y ||
>>>> LEDS_CLASS [=y]=IWLWIFI [=y])
>>>>
>>>> Move the MAC80211 dependency into IWLWIFI_LEDS so that we avoid this
>>>> configuration.
>>>>
>>>> Signed-off-by: Sinan Kaya <okaya@kernel.org>
>>>> ---
>>>
>>> Thanks for your patch! But we already have another patch to fix this
>>> issued queued for 5.0-rc4 (it's currently in wireless-drivers.git):
>>>
>>> https://patchwork.kernel.org/patch/10762079/
>>
>> Is it possible to queue this up soon? There is an effort to clean up
>> linux-next against randconfig failures and this issue showed up there.
> 
> It already should be in linux-next:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=ec5aecc0b227f5509d25853537f989ca303e2be1
> 
> But it's not in Linus' tree, yet.
> 

Thanks, let me grab a recent linux-next tag.