Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7611413imu; Tue, 22 Jan 2019 08:40:17 -0800 (PST) X-Google-Smtp-Source: ALg8bN4NHIBCJgvOaLVdpfGVnyELpZtAPluIid7P7qqOuU4s70TZ7a7Es6v/N0uuszQ9N8LvaIYq X-Received: by 2002:a63:9041:: with SMTP id a62mr32013505pge.163.1548175217476; Tue, 22 Jan 2019 08:40:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548175217; cv=none; d=google.com; s=arc-20160816; b=Irsdxf5Mv4OXgeHagV56eD/tX+kx8wb/4QY4xmEmOiuy5fs595ItdX1Yuj0/7CFm9r GPoBvfzBUlGHBvhEjAMC7bHly/+lR69ZpnTEHXeaZGvye/E7oEsGTRV/bygYwgUMY6yA j4zgTWMWSreQrUfEeQCoUvQqh4ZWVG0pfIxvzlUWySJBd2Tp6VULmSKkoDw9pmu5C7W5 L2icw2SWmq8XSIkEdZHYx9gaacMdGnjW7+MKrga/I5OQ8SwfFRet/j6PgQQZUxnSB2Un 27Jwd+d1Ia3f7jbOX1zUtN1i3+CSkto1cjy0gRJ4EK6jdUNIYRvpYbU1WRsZoJhAniAQ H9Bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=U7aFavQ9SVIjs8S87Gj/N/MPWyoAhbEC0162UJiW8f0=; b=kQ1F/n7s8+6qqS1rICiYEXtgLTFvFak4tGUmzQdKV5jASPHTvfrlI+j1Rt5dHf2qv+ eJGF3AtMVMtT9QAiIp3KFbeQQCVMFkMYPlD1NeczY4T8mLQV5uUCLStGTuopJIQDhnHM eraSdo7BO6OIHPQumnp18ru5ZArykRevaybx2TJ1jkJttiJji+s3FUeVkUCTW1iyPxOZ mY0uF+6yANiKwa9z6fRd0E+Unb8hBeEDlUJFRTNvRRGH7FwIAHppxAbFlzFfbceZvn5U EmZ6SemuggKxWjhh8n/AhEfEXknMnYBSdOuL2t5BnLYRMhBIXFGdluPlVQ1sN91HDqGH l8RA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c17si16395953pgl.385.2019.01.22.08.40.01; Tue, 22 Jan 2019 08:40:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729441AbfAVQhy (ORCPT + 99 others); Tue, 22 Jan 2019 11:37:54 -0500 Received: from mga18.intel.com ([134.134.136.126]:39738 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729360AbfAVQhx (ORCPT ); Tue, 22 Jan 2019 11:37:53 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2019 08:37:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,507,1539673200"; d="scan'208";a="111771908" Received: from unknown (HELO localhost.localdomain) ([10.232.112.69]) by orsmga008.jf.intel.com with ESMTP; 22 Jan 2019 08:37:52 -0800 Date: Tue, 22 Jan 2019 09:36:50 -0700 From: Keith Busch To: "Rafael J. Wysocki" Cc: Greg Kroah-Hartman , Dan Williams , Linux Kernel Mailing List , ACPI Devel Maling List , Linux Memory Management List , Dave Hansen Subject: Re: [PATCHv4 05/13] Documentation/ABI: Add new node sysfs attributes Message-ID: <20190122163650.GD1477@localhost.localdomain> References: <20190116175804.30196-1-keith.busch@intel.com> <20190116175804.30196-6-keith.busch@intel.com> <20190119090129.GC10836@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.1 (2017-09-22) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 20, 2019 at 05:16:05PM +0100, Rafael J. Wysocki wrote: > On Sat, Jan 19, 2019 at 10:01 AM Greg Kroah-Hartman > wrote: > > > > If you do a subdirectory "correctly" (i.e. a name for an attribute > > group), that's fine. > > Yes, that's what I was thinking about: along the lines of the "power" > group under device kobjects. We can't append symlinks to an attribute group, though. I'd need to create a lot of struct devices just to get the desired directory hiearchy. And then each of those "devices" will have their own "power" group, which really doesn't make any sense for what we're trying to show. Is that really the right way to do this, or something else I'm missing?