Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7680133imu; Tue, 22 Jan 2019 09:45:28 -0800 (PST) X-Google-Smtp-Source: ALg8bN4UeLBGg87HuvufU2EU+cluOs5oG36EQ1vg94pNBbJMVjl3YnXxVqZaoHGeIvsLsrcUQ1Lk X-Received: by 2002:a62:3541:: with SMTP id c62mr34136979pfa.19.1548179128331; Tue, 22 Jan 2019 09:45:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548179128; cv=none; d=google.com; s=arc-20160816; b=t4fUg4bpMgdcvIZGjb2Z8wzS9NMb65bzjnu1/MISOFS+Cv8qLpMxQzhZgg3wKqSQAn A9HVSiV9xS2/BVgMXTIFwLPhaOQiI65zBlFDYWjMpjJ4f4tiNrcI4+QWjwE+mzFRrJ0b eWDNkoMNGTtGvPapFrXH3+ek1eDguOHePX1ZfoZSHhClnVqqOFvdnEttEZwdKH7HQtK2 upQcq4brXFr1xXTGICPPbmomAQig6roTNS2Mc37RGfPZMrXdf+HmoAPKVnl6wdTuXPdJ P1Rbtos/zRfoUyAKKHBYvLauqHvoWBdbFaEEz+pCpOkcsCdrczLMhV61EPFBUa4qk5zK 2mzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=p8B/MKL+eGNrXIYsqEQjCGFPvZ6DO5NeKqA1FWaD2Qo=; b=h6ttQS+DOxawU4qYPPetN2SGoIlafKP8dxxGAFYoN3ct5lHwAxdDKgikFiufXQzGfN /cgn8S9Nw1KOF3877Dnf/e1cl4ETSX4p++nIm2h9M31AFA7EyAMJrSj2VjWm3gzFW53p H2A0lxWpr28tyZXnzGyNT/DCws+9NSQfb/njHcZpfoW2Gk2MuSQ6w/gbpkCQjP9Rw8/N e4QB5hIhAVSB0PajuvPWLyb20ognGygUc63WRxB60fSxSCgE1vVy1177x4zxrE+yjrCJ hO/ueFsR5kPTKbeK1xGG93zLMvEQv6Uh/cN66R3f5ADwEFORKp7QZyrpnjbffo8a5Hay f/lw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u+ZmHTa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f61si17055547plb.51.2019.01.22.09.45.12; Tue, 22 Jan 2019 09:45:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=u+ZmHTa7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725994AbfAVRnA (ORCPT + 99 others); Tue, 22 Jan 2019 12:43:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:59676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbfAVRnA (ORCPT ); Tue, 22 Jan 2019 12:43:00 -0500 Received: from localhost (unknown [77.138.135.184]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CA52220879; Tue, 22 Jan 2019 17:42:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548178979; bh=7w5nNfW96UrGImUpHTbVooxyIZkFfUVaOnAnfWrDHDY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=u+ZmHTa7aDPzJAx48E1YQ9sCjs3AJmu/5pKLsJ2vBEC1etp4vxtwhlV3rbE3BYNJA fW3QBMA0SEprSj+C/BP89i7tBXj8kyYoBbtEBrcu8NiiCfUTywr02eK7G66QLIpAUw CuEnhytjRGWopt+j2tzOm6CLpXCoDa2wN6PYBYns= Date: Tue, 22 Jan 2019 19:42:54 +0200 From: Leon Romanovsky To: Greg Kroah-Hartman Cc: Doug Ledford , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org Subject: Re: [PATCH 5/8] infiniband: mlx5: no need to check return value of debugfs_create functions Message-ID: <20190122174254.GE3604@mtr-leonro.mtl.com> References: <20190122151800.15092-1-gregkh@linuxfoundation.org> <20190122151800.15092-6-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="6TrnltStXW4iwmi0" Content-Disposition: inline In-Reply-To: <20190122151800.15092-6-gregkh@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --6TrnltStXW4iwmi0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 22, 2019 at 04:17:57PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Leon Romanovsky > Cc: Doug Ledford > Cc: Jason Gunthorpe > Cc: linux-rdma@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/infiniband/hw/mlx5/cong.c | 15 +++----- > drivers/infiniband/hw/mlx5/main.c | 8 ++--- > drivers/infiniband/hw/mlx5/mlx5_ib.h | 8 +---- > drivers/infiniband/hw/mlx5/mr.c | 51 +++++----------------------- > 4 files changed, 18 insertions(+), 64 deletions(-) > Thanks, Acked-by: Leon Romanovsky --6TrnltStXW4iwmi0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJcR1YeAAoJEORje4g2clinHPAP/A7jQ7mZ7g718Tan+qeF6TDu s9RE2ISUf3M4c9GDplyR2dB4vSRQYc0HT2uYCEXfBQlLGlwR+Twxgq8SMU9tggXX rFsvYGAwjEu0AUBWFl3xDht4oeo+yGYeDRKmP7Hn/U4S3VwCBPSUpiHhnQ0Fe+Mt IvZZMLf1VSHJvqat+xGtGujZ6HbMHWoNCSFUJaR0vtsIONd7zL5vj+39gLwWNc/q TleLp19nEDTefnrmL4eMAqXcQ7xX789P2SLDPMg3msrQimE1yi65vVPCtzTEiIfK pH1LAgD1nL/N0YQG2cXAU0ekhh8pIbvWEDVdrFeAwMFfURXiY5JWevxB2vlv9Aei ErelGBMHYBvA+dc306tqi96rYuLZe7tvNQg9XGpKMv70Mcn8F07jCb8i5C4sOfET C4VFhivP3imDilBkBOYSlKpnGkwqaFA8nBxCe4Acy2KqX+tuWLGJLKqmrK026rIU xRCU9mit4mvXss4QscQs3Uhp9XDwe+e0eZMmQkjW4Tn+nX311Zt1CJDrr/sodBR+ s24TPVxqYOXo/eqzTuc3tlVJvap2RLC65uajcS8EWu6+Bge33ea+hqsjfVLTIDG1 nbDYniuZURoIe6oKmblJTwB3YXGfthhk4MtcEUQGMRucEE7vxQbHX/3F6QiYwQIl 6Jq/Eqw2PMqrHVbpS6zL =cVsM -----END PGP SIGNATURE----- --6TrnltStXW4iwmi0--