Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7702733imu; Tue, 22 Jan 2019 10:08:04 -0800 (PST) X-Google-Smtp-Source: ALg8bN4lDABJAHH32mXbe2bPEMJRoD4miZg44M/jkm0FSFyn4aOP86+P4+rfRYbZBi8sd01REGLx X-Received: by 2002:a62:b2c3:: with SMTP id z64mr34022769pfl.120.1548180484493; Tue, 22 Jan 2019 10:08:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548180484; cv=none; d=google.com; s=arc-20160816; b=Tw9QqChkET+nSZHw/uwyZgEyZzsEN80mSk/3LRNRU4KaFu2z/oaufSW642nvvkcjS0 S/dtuBf3p8qyC8DytvIlgS99nT3bCKp5ddeNVPO+eA8pXJiZylp/ceZkYo7yW9XM8IDl +sFs92zSVepNCgD4Ver4zEzL68h4Sr87w2KFrVl9lplptaiOKZJpEdRhhdBeB8LbAUyU XkWb2kXDx9r16JPTS3uoiZ9BjM4E4mR/nexugD7QnNtjLNSSp+6gvgpcjiOeMb8Gc1MR UxVrAQnFf+989cRdKUYcCBfKpsp0bpLvQrj5szQZC21Ch67NibQJu4N975j0X18TlkuU yCiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4J7gMyrTDKK2utGOIEHca0jds2ocC55A4rfMNTimQO8=; b=x8FJQ4elctfzIv1qyopXCwiQCkS/ciXC5v22X03f9OOt+y0yDmv5fdCedd3JhpnYXh pa33wN20HqIArjgJj+gG2ZgUTqg/0Smtn3BRVkTgbV1+VpiIJpTI3BR46Kj+EgTUvCcL YUg+fRQZhGKbq6w7C+kVZcF7NA/g/yITdEE7CDJMtTh6c138HNAlD8vAsq4t1sadoO6u Wt3bYx11AjqEe2aezbs9q057U0li0Lu6pfbFFwGcffrMEOlmQHSmblhZcz1btG8sHcZC dkuI/IX1+VpDveaJs/5ddgjKZrxKLQ7rtwfoB5hNcDyY0hDG0aqTuWKGWYErBSiby+oT y9XQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d4si16145808pls.348.2019.01.22.10.07.48; Tue, 22 Jan 2019 10:08:04 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725930AbfAVSGZ (ORCPT + 99 others); Tue, 22 Jan 2019 13:06:25 -0500 Received: from mail.bootlin.com ([62.4.15.54]:45810 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725899AbfAVSGZ (ORCPT ); Tue, 22 Jan 2019 13:06:25 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 10BF0207A3; Tue, 22 Jan 2019 19:06:23 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from localhost (unknown [80.12.58.130]) by mail.bootlin.com (Postfix) with ESMTPSA id A96C6207AB; Tue, 22 Jan 2019 19:06:12 +0100 (CET) Date: Tue, 22 Jan 2019 19:06:11 +0100 From: Alexandre Belloni To: Eric Wong Cc: Alessandro Zummo , Sylvain Chouleur , Patrick McDermott , linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] rtc: cmos: ignore bogus century byte Message-ID: <20190122180611.GG16702@piout.net> References: <20190106082103.evfgarznrskd4oxh@dcvr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190106082103.evfgarznrskd4oxh@dcvr> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/01/2019 08:21:03+0000, Eric Wong wrote: > Older versions of Libreboot and Coreboot had an invalid value > (`3' in my case) in the century byte affecting the GM45 in > the Thinkpad X200. Not everybody's updated their firmwares, > and Linux <= 4.2 was able to read the RTC without problems, > so workaround this by ignoring invalid values. > > Fixes: 3c217e51d8a272b9 ("rtc: cmos: century support") > > Cc: Alexandre Belloni > Cc: Alessandro Zummo > Cc: Sylvain Chouleur > Cc: Patrick McDermott > Cc: linux-rtc@vger.kernel.org > Signed-off-by: Eric Wong > --- > drivers/rtc/rtc-mc146818-lib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com